Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mekanism ignores the client sounds off config setting #983

Closed
FnordMan opened this issue Mar 13, 2019 · 15 comments
Closed

Mekanism ignores the client sounds off config setting #983

FnordMan opened this issue Mar 13, 2019 · 15 comments

Comments

@FnordMan
Copy link

Modpack version
Input version here1.58

Can the issue be reproduced?
Yes

Issue
Subject line says it all, friend also says that it ignores sound mufflers as well.

@NielsPilgaard
Copy link
Collaborator

You need to restart the pack for the config to take effect I believe, did you?

@NielsPilgaard NielsPilgaard added the Status: Awaiting Information Waiting for additional information label Mar 13, 2019
@MorganSimic
Copy link
Collaborator

Previously the sound setting would take effect immediately. And i can confirm, Mekanism does not respect the settings. I did set the sound to zero and restarted the client but to no avail. Mekanism machines are still making sounds.
Quick look on the Meknica github revealed no issue of that sort yet.

@NielsPilgaard
Copy link
Collaborator

Other than this change ofc :P
Overhauled entire sound system to work reliably with mufflers; reduced size of sound files by 90%

@NielsPilgaard NielsPilgaard added Mod Issue and removed Status: Awaiting Information Waiting for additional information labels Mar 13, 2019
@FnordMan
Copy link
Author

Honestly a better solution would be to switch back to the "original" Mekanism now that it's updating again.

@NielsPilgaard
Copy link
Collaborator

...?
That wouldn't fix the issue.

@MaxNeedsSnacks
Copy link
Collaborator

I think the config option broke when switching to DZ actually

@NielsPilgaard
Copy link
Collaborator

Ah ^^' But the sound being actually fixed would be preferable imo.

@metnavman
Copy link

Seconding this bug. Was about to make a new issue when a quick search showed this open issue! Nothing I've done with the Config has made the machines stop making noise.

@dizzyd
Copy link

dizzyd commented Mar 17, 2019

Hi all - this was pointed out to me on the Mekanica discord. There was a check missing and the next release will have it incorporated. Let me know if you have any other questions!

@dizzyd
Copy link

dizzyd commented Mar 17, 2019

@NillerMedDild - if there is a specific back release you'd like me to port this patch to, just let me know.

@NielsPilgaard
Copy link
Collaborator

Good work, thanks!

@MaxNeedsSnacks
Copy link
Collaborator

This should be fixed upon release of 1.59 (that is if Niller updates Mekanica to at least this version or switches back to the "regular" Mekanism.)

@NielsPilgaard
Copy link
Collaborator

We're staying with Mekanica at least for the time being, the support and response time is great.

@dizzyd
Copy link

dizzyd commented Mar 21, 2019

We're releasing 1.1.0 tomorrow morning (GMT+7). It has this and a bunch of other fixes.

@MaxNeedsSnacks
Copy link
Collaborator

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants