Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe curve element creation #52

Open
aleasims opened this issue Sep 14, 2023 · 1 comment
Open

Safe curve element creation #52

aleasims opened this issue Sep 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aleasims
Copy link
Contributor

Methods __zkllvm_curve_*::from_coordinates are unsafe now.

Because not every pair of base coordinates belong to curve, we need to check this before creation. But how we can do it? And how llvm.assigner.curve.init intrinsic will react on invalid coordinates?

Also we propose to use TryFrom<(__zkllvm_field_X_base, __zkllvm_field_X_base)> interface for curve element creation.

@aleasims
Copy link
Contributor Author

Waiting for instrinsic like llvm.assigner.curve.is_well_formed come to the LLVM and then implement safe curve initialization.

@aleasims aleasims added the enhancement New feature or request label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant