Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with llvm-project submodule #18

Open
aleasims opened this issue May 26, 2023 · 0 comments
Open

Deal with llvm-project submodule #18

aleasims opened this issue May 26, 2023 · 0 comments
Labels
discussion Feel free to discuss this

Comments

@aleasims
Copy link
Contributor

aleasims commented May 26, 2023

Rust has a submodule llvm-project, which is a fork of original LLVM. It can be built with rustbuild and used by rustc. However since we only use rslang with circifier (which is also a LLVM fork), we probably don't need this submodule at all.

Replacing this submodule to a circifier may look sound, but since circifier is not a standalone repo we will have hard times compiling it.

The suggestion is to fully remove this submodule. If one would like to build rustc from source he then should use umbrella repo.

The only problem about removing this submodule that I see now, is that rustbuild may attempt to build LLVM and expects it to be at this path. However again: building from sources should be done from umbrella repo, where building LLVM is configured correctly.

Rust patches to LLVM

The other point here is should we bring Rust patches from llvm-project into circifier. llvm-project is not tightened to LLVM version, but to Rust version. Having another one source of updates may make updating circifier a real pain.

Rust build system automatically detects whether there are Rust to LLVM patches or not, depending on provided llvm-config path (see llvm-has-rust-patches config option). So basically Rust must work fine without these patches.

@aleasims aleasims added the discussion Feel free to discuss this label May 26, 2023
@aleasims aleasims self-assigned this May 26, 2023
@aleasims aleasims removed their assignment Jul 5, 2023
@aleasims aleasims moved this from New to Backlog in zkLLVM + Proof Market Toolchain Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Feel free to discuss this
Projects
Status: Backlog
Development

No branches or pull requests

1 participant