Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Uncaught exception "IndexError" when calling get_project_parameter #194

Open
menathan opened this issue Jan 2, 2025 · 1 comment · May be fixed by #197
Open

[BUG] Uncaught exception "IndexError" when calling get_project_parameter #194

menathan opened this issue Jan 2, 2025 · 1 comment · May be fixed by #197
Assignees
Labels
bug Something isn't working
Milestone

Comments

@menathan
Copy link

menathan commented Jan 2, 2025

Describe the bug
There's an uncaught exception "IndexError" when calling get_project_parameter without any value set in BrickflowEnvVars.BRICKFLOW_PROJECT_PARAMS

To Reproduce

from brickflow.context import ctx
ctx.get_project_parameter("key1") ## uncaught IndexError

Run via cli:

bf projects deploy -p DEFAULT -e local

Expected behavior
No error should be raised, when project parameter is not found, just return an empty string.

Screenshots
N/A

Cloud Information
N/A

Desktop (please complete the following information):
N/A

Additional context
N/A

@menathan menathan added the bug Something isn't working label Jan 2, 2025
@pariksheet pariksheet self-assigned this Jan 14, 2025
@pariksheet pariksheet added this to the v1.3.1 milestone Jan 14, 2025
@pariksheet pariksheet assigned menathan and unassigned pariksheet Jan 14, 2025
@pariksheet
Copy link
Collaborator

or user can provide default value

ctx.get_project_parameter("key1", default= "nike")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants