Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Configure webhook notification at task level #192

Open
4 tasks done
riccamini opened this issue Dec 17, 2024 · 1 comment
Open
4 tasks done

[FIX] Configure webhook notification at task level #192

riccamini opened this issue Dec 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@riccamini
Copy link
Contributor

Is your feature request related to a problem? Please describe.
it should be possible to configure a webhook notification at task level as it is currently possible for email notifications. Looks like WorkflowWebhookNotifications is missing from task settings.

Cloud Information

  • AWS
  • Azure
  • GCP
  • Other

Describe the solution you'd like
WorkflowWebhookNotifications to be added to TaskSettings in engine.task. We can see that email notifications are there while webhook ones are missing:

@dataclass(frozen=True)
class TaskSettings:
    email_notifications: Optional[EmailNotifications] = None
    notification_settings: Optional[TaskNotificationSettings] = None
    timeout_seconds: Optional[int] = None
    max_retries: Optional[int] = None
    min_retry_interval_millis: Optional[int] = None
    retry_on_timeout: Optional[bool] = None
    run_if: Optional[TaskRunCondition] = None

Describe alternatives you've considered

@riccamini riccamini added the enhancement New feature or request label Dec 17, 2024
@pariksheet pariksheet changed the title [FEATURE] Configure webhook notification at task level [FIX] Configure webhook notification at task level Jan 14, 2025
@pariksheet pariksheet added this to the v1.3.1 milestone Jan 14, 2025
@pariksheet pariksheet added bug Something isn't working and removed enhancement New feature or request labels Jan 14, 2025
@muhammadwaqas0505
Copy link

Assisgning to myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants