Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong with the newlines. #5

Open
adonig opened this issue Apr 6, 2018 · 5 comments
Open

Something is wrong with the newlines. #5

adonig opened this issue Apr 6, 2018 · 5 comments

Comments

@adonig
Copy link

adonig commented Apr 6, 2018

Something seems to be wrong with the newlines. One can possibly use sed to fix it.

screen shot 2018-04-06 at 14 38 41

@MajickTek
Copy link

This is normal. They are newlines meant for powerpc macs and are made for compatibility with the ide used to build this game

@adonig
Copy link
Author

adonig commented Apr 6, 2018

Oh, I see. Hm, Do you think it is possible to bring the GitHub guys to support them? :)

@bsinky
Copy link

bsinky commented Apr 6, 2018

Just curious, what is the newline sequence PowerPC macs used? If it's not CRLF or LF, what is it?

Edit: By reading through pull request #2, looks like the line endings in use are just CR.

@sharkitgood
Copy link

Yeah, given this particular version of the source is being preserved for posterity, @NightDiveStudios may be hesitant to apply changes which, as mentioned in PR #2, could potentially affect the intended build environment. A note could be added in the readme if it's known to cause problems, perhaps allowing the changes in a separate branch -- though a number of forks that have changed the format do exist already if you are looking to browse the code on the web right away.

They've also mentioned that a cleaned up version they've spent a few months with is coming soon, which will undoubtedly be configured for modern environments.

@HiPhish
Copy link

HiPhish commented Apr 7, 2018

+1 for adding a note to the README, otherwise people will keep opening issues and pull requests about this. The problem really lies with the way GitHub renders the code listings and should be fixed there. Sadly GitHub is proprietary software, and so we are at the mercy of the company until someone bothers to look into this particular issue. There are already code hosting sites which are Free Software, this could have been a trivial issue to sort out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants