Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The coding progress rate exceeds 100% #1279

Closed
inoyakaigor opened this issue Feb 7, 2024 · 2 comments · Fixed by #1293
Closed

[Bug] The coding progress rate exceeds 100% #1279

inoyakaigor opened this issue Feb 7, 2024 · 2 comments · Fixed by #1293
Assignees
@NickeManarin
Labels
🔷 Bug 🐛 Type • An undesired situation happens. ⬜ Completed Status • Issue solved.

Comments

@inoyakaigor
Copy link

Describe the bug
Often percenatge of encoding process exceed 100%

To Reproduce
Steps to reproduce the behavior:
Just tryed to save a video with these config
screen to gif

Expected behavior
Progress must not exceed 100%

Screenshots
Link to video (Can't attach because it exceed GH file size limit)
But there is most important frame:
videoframe_70020

Desktop (please complete the following information):

  • OS: Win 11
  • Version 2.40.1
  • ffmpeg 6.1.1

Additional context
The video was shot when I set the latest version of ffmpeg 6.1.1 but I've met this bug with in box ffmpeg 4
@inoyakaigor inoyakaigor added ⬜ Pending Status • This issue stills needs to be analyzed. 🔷 Bug 🐛 Type • An undesired situation happens. labels Feb 7, 2024
@pawlos
Copy link
Contributor

pawlos commented Mar 10, 2024

Yeah, there's an issue when the ffmpeg encoder produces duplicated frames. The returned frame count number is such case can be greater then one that was passed. We should consider reducing the frame number by the duplicated ones. I'll create a PR to fix this.

@pawlos
Copy link
Contributor

pawlos commented Mar 10, 2024

Ok, this is a bit more interesting that initially anticipated.

One of the output lines from ffmpeg:

frame= 1 fps=0.0 q=32.7 size= 0kB time=-00:00:00.04 bitrate=N/A dup=12 drop=0 speed=N/A

So it's not just a matter of removing the dup's as that would produce problems on the other end. Values below 0%. Investigating.

@pawlos pawlos mentioned this issue Mar 23, 2024
Merged
@NickeManarin NickeManarin added ⬜ Completed Status • Issue solved. and removed ⬜ Pending Status • This issue stills needs to be analyzed. labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickeManarin NickeManarin

Labels
🔷 Bug 🐛 Type • An undesired situation happens. ⬜ Completed Status • Issue solved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix calculation of the processed frame for Ffmpeg pawlos/ScreenToGif
3 participants
@inoyakaigor @pawlos @NickeManarin