Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements when editing cells containing xml or json #47

Closed
wants to merge 34 commits into from
Closed

Conversation

mhalverson
Copy link
Contributor

Hi Igor,
The only change is the last commit, by me:

(1) When editing xml or json, the "save" button has been renamed "mark for save".
(2) When you click on "mark for save", the button for actually saving modified rows to HBase is highlighted. Before, you had to click "mark for save", then click on a separate row, before you were allowed to actually save the changes.

Cheers,
-Matt Halverson

Igor Cher and others added 4 commits July 15, 2013 13:21
(1) When editing xml or json, the "save" button has been renamed "mark for save".
(2) When you click on "mark for save", the button for actually saving modified rows to HBase is highlighted. Before, you had to click "mark for save", then click on a separate row, before you were allowed to actually save the changes.
@icher-g
Copy link

icher-g commented Aug 26, 2013

Hi Matt,

There are too many changes so the merge cannot be performed automatically and manually seems to be very difficult as well. Can you send me the changes you've done so I will add them manually to the code on my side.

Thanks,
Igor.

@mhalverson
Copy link
Contributor Author

Hi Igor,

Sure thing.

I created an IntelliJ patchfile and attached it to this email (to apply it,
go to IntelliJ -> VCS -> Apply Patch).
If you are developing H-Rider outside of IntelliJ, then the patchfile is
very human-readable... it's only 10 lines difference across only 3 files,
so I'd just open it up in Notepad and do the edits manually.
Alternatively, I can actually sit down and learn how Git works and try to
submit a more reasonable pull request ;)

-Matt

On Mon, Aug 26, 2013 at 2:27 AM, Igor Cher [email protected] wrote:

Hi Matt,

There are too many changes so the merge cannot be performed automatically
and manually seems to be very difficult as well. Can you send me the
changes you've done so I will add them manually to the code on my side.

Thanks,
Igor.


Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-23252222
.

icher-g pushed a commit that referenced this pull request Aug 28, 2013
Usability improvements when editing cells containing xml or json
@icher-g
Copy link

icher-g commented Aug 28, 2013

Implemented

@icher-g icher-g closed this Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants