Should toggle fullscreen instead of changing video mode

[ersohnstyne]

BUG: Fullscreen just changed but it recreates Window againon the graphics screen!
TO FIX: Change the window between fullscreen and windowed mode without recreate the window:

// Funcion name:
// int video_action(int tok, int val)

// INCORRECT:
r = video_mode(val, w, h);

// CORRECT:
r = video_fullscreen(val);

[parasti]

"Bug" means "wrong results". This is not a bug. There is no "correct" or "incorrect" here. This is just doing something differently.

Should it be done? Maybe.

[ersohnstyne]

FOR THE BEST SOLUTION: Use the toggle fullscreen in the graphic settings without recreating the new window. Go to st_common.c in the function video_action(int tok, int val) and change as follows:

        goto_state_full(&st_null, 0, 0, 1);
        r = video_fullscreen(val);
        if (r)
            goto_state_full(&st_video, 0, 0, 1);
        else
        {
            r = video_fullscreen(val);
            if (r)
                goto_state_full(&st_video, 0, 0, 1);
            else
            {
                // Uncomment, if new config features is implemented
                //config_set_d(CONFIG_GRAPHIC_RESTORE_ID, 0);
                //config_set_d(CONFIG_GRAPHIC_RESTORE_VAL1, val);
            }
        }

[ersohnstyne]

Secondly, if you're using Mojang Development and using resizeable window, delete that as follows:

static int video_gui(void)
{
    // ...
    if ((id = gui_vstack(0)))
    {
        // DELETE HERE ON BOTTOM
        char resolution[sizeof("12345678 x 12345678")];
        const char* display;
        int dpy = config_get_d(CONFIG_DISPLAY);

        if (!(display = SDL_GetDisplayName(dpy)))
            display = _("Unknown Display");

        gui_space(id);

        if ((jd = conf_state(id, _("Display"), "Super Longest Name", VIDEO_DISPLAY)))
        {
            gui_set_trunc(jd, TRUNC_TAIL);
            gui_set_label(jd, display);
        }

        sprintf(resolution, "%d x %d",
            video.window_w,
            video.window_h);

        if ((jd = conf_state(id, _("Resolution"), resolution,
            VIDEO_RESOLUTION)))
        {
            /*
             * Because we always use the desktop display mode, disable
             * display mode switching in fullscreen.
             */

            if (config_get_d(CONFIG_FULLSCREEN))
            {
                gui_set_state(jd, GUI_NONE, 0);
                gui_set_color(jd, gui_gry, gui_gry);
            }
        }
        // DELETE HERE ON TOP
    }
}

[parasti]

What.

[ersohnstyne]

Build-in resolutions no longer supported during using resizeable window. The graphics will be toggled to fullscreen and windowed mode in the graphics options without recreate any window. Using Emscripten does not work except pressing F11.