Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3D ROIs #554

Closed
4 of 10 tasks
ajtritt opened this issue Jul 9, 2018 · 3 comments
Closed
4 of 10 tasks

Add support for 3D ROIs #554

ajtritt opened this issue Jul 9, 2018 · 3 comments
Assignees
Labels
category: enhancement improvements of code or code behavior
Milestone

Comments

@ajtritt
Copy link
Member

ajtritt commented Jul 9, 2018

  1. Feature Request
  • Replace manifold with start coordinate + deltas
  • Add ImagingRegion that supports 2D or 3D regions
  • Add RegionSegmentation
    - can be a copy with PlaneSegmentation with ImagingRegion swapped for ImagingPlane
  • add Pending deprecation to ImagingPlane and PlaneSegmentation
  • add zero or more RegionSegmentation to ImageSegmentation
  • Add 3 dimensions where only 2 dimensions are allowed:
    - PixelMasks
    - ImageMasks

Problem/Use Case

Some labs are imaging across volumes. Currently, the schema is restricted to imaging across planes.

Checklist

  • Have you ensured the feature or change was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
@ajtritt ajtritt added the category: enhancement improvements of code or code behavior label Jul 9, 2018
@ajtritt ajtritt added this to the NWB 2.0 Full milestone Jul 9, 2018
@bendichter
Copy link
Contributor

What's the purpose of having ImageSegmentation and RegionSegmentation? What if we just had ≥0 ImageSegmentation objects and did away with RegionSegmentation

@bendichter
Copy link
Contributor

also, are we including the idea that pixel mask is removed and rendered on the fly?

@ajtritt
Copy link
Member Author

ajtritt commented Jul 9, 2018

What's the purpose of having ImageSegmentation and RegionSegmentation? What if we just had ≥0 ImageSegmentation objects and did away with RegionSegmentation

For consistency with the current schema.

also, are we including the idea that pixel mask is removed and rendered on the fly?

Lets keep pixel mask for now. We can add a function for autogenerating a pixel mask from an image mask to deal with the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

No branches or pull requests

2 participants