Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ophys metadata schema #738

Closed
CodyCBakerPhD opened this issue Apr 11, 2024 · 3 comments
Closed

[Bug] Ophys metadata schema #738

CodyCBakerPhD opened this issue Apr 11, 2024 · 3 comments
Assignees

Comments

@CodyCBakerPhD
Copy link
Collaborator

Describe the issue

Using a built version (particularly the current draft of 0.0.15 on Windows) but don't know if it's problem on dev (assuming it is)

Make a new pipeline, and select a single data format (Bruker single tiff)

Specify the GIN file .../ophys_testing_data/imaging_datasets/BrukerTif/NCCR32_2023_02_20_Into_the_void_t_series_baseline-000

Proceed to metadata customization page, fill everything in and try to proceed

Steps to Reproduce

index-b8682a56.js:57040 Uncaught (in promise) Error: Ophys requires property "definitions".
at JSONSchemaForm.throw (index-b8682a56.js:57040:11)
at JSONSchemaForm.validate (index-b8682a56.js:57087:19)
at async GuidedFooter.onNext [as __onNext] (index-b8682a56.js:182993:9)

Operating System

Windows

GUIDE Version

0.0.15

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

@CodyCBakerPhD
Copy link
Collaborator Author

After this one we can probably cut a release

@garrettmflynn
Copy link
Member

This has a fairly simple cause. Definitions should not exist on the JSON Schema properties itself but one level lower: https://json-schema.org/understanding-json-schema/structuring#bundling

Looks like something is wrong with the BrukerTiffSinglePlaneConverter schema.

@CodyCBakerPhD
Copy link
Collaborator Author

This has been patched locally and official solution in progress on NeuroConv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants