Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload summary Files uploaded #658

Closed
bendichter opened this issue Mar 11, 2024 · 2 comments · Fixed by #665
Closed

Upload summary Files uploaded #658

bendichter opened this issue Mar 11, 2024 · 2 comments · Fixed by #665

Comments

@bendichter
Copy link
Collaborator

bendichter commented Mar 11, 2024

Describe the issue

Using the independent Upload feature

image

Here under Files Uploaded, it lists a directory, not files.

Steps to Reproduce

see above

Operating System

OSX

GUIDE Version

main branch

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

@garrettmflynn
Copy link
Member

garrettmflynn commented Mar 11, 2024

From the GUIDE, it's difficult for me to know exactly what files were successfully uploaded to DANDI if I'm provided folders to aggregate over. This doesn't seem to be returned from the automatic_dandi_upload.

@CodyCBakerPhD Could you have this function return a list of successfully uploaded file paths? If not, I'll need a description of the strategy for discovering files to upload, so this can be replicated on the GUIDE end.

@CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD Could you have this function return a list of successfully uploaded file paths?

Give this a try: catalystneuro/neuroconv#773

This indirectly assumes that if there was an error during upload, it would raise in the stderr and not return anything, and therefore if it returns something it means it uploaded successfully

Otherwise the upload function via the DANDI API does not itself indicate such success/failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants