Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make staging key in settings not strictly required #469

Closed
CodyCBakerPhD opened this issue Oct 22, 2023 · 1 comment · Fixed by #470
Closed

Make staging key in settings not strictly required #469

CodyCBakerPhD opened this issue Oct 22, 2023 · 1 comment · Fixed by #470
Assignees

Comments

@CodyCBakerPhD
Copy link
Collaborator

I'd suggest separating the DANDI keys into different tabs on the settings, and also having only the main key be required (i.e., show up as red status when missing)

The staging, for the majority of actual use cases beyond the alpha testing and optional tutorial completion, will mainly be for developers (also requires different permissions on DANDI side, apparently) - so I'd either not show a status requirement or if you need to, show it as yellow instead of red

@garrettmflynn
Copy link
Member

Thanks for the suggestion! I'd made the staging API key optional on the schema—but I didn't stop validating it for the correct form, which failed when it was empty.

Just pushing a PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants