Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Expose number of jobs/threads for DANDI upload #426

Closed
CodyCBakerPhD opened this issue Oct 7, 2023 · 4 comments
Closed

[Feature]: Expose number of jobs/threads for DANDI upload #426

CodyCBakerPhD opened this issue Oct 7, 2023 · 4 comments
Assignees

Comments

@CodyCBakerPhD
Copy link
Collaborator

Will require exposing these to NeuroConv as well

A number of people (about 50%) ran into segmentation faults during upload that traced back to joblib in the dandi organize (which would also have then affected parallel upload as well)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Oct 7, 2023
@garrettmflynn
Copy link
Member

Do you want this exposed as a user-defined value, for the REST API request, or simply just as a hardcoded value for the automatic_dandi_upload call?

@CodyCBakerPhD
Copy link
Collaborator Author

Do you want this exposed as a user-defined value, for the REST API request, or simply just as a hardcoded value for the automatic_dandi_upload call?

A user selection is desired - I'll put together the schema for it when I expose it, as long as there's an integer range selector component I assume it should work fine? (or I can also generate an enum of strings on the fly if that's easier?)

@garrettmflynn
Copy link
Member

Either works. If you'd like to restrict users to a certain set of non-consecutive values (e.g. powers of 2), I'd use enum—otherwise we could also specify a min and max value.

@CodyCBakerPhD CodyCBakerPhD pinned this issue Oct 30, 2023
@CodyCBakerPhD
Copy link
Collaborator Author

CodyCBakerPhD commented Nov 6, 2023

fixed by #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants