Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: ROS3 HDF5 driver support #469

Closed
2 tasks done
yarikoptic opened this issue Nov 4, 2022 · 2 comments · Fixed by #471
Closed
2 tasks done

[Feature]: ROS3 HDF5 driver support #469

yarikoptic opened this issue Nov 4, 2022 · 2 comments · Fixed by #471

Comments

@yarikoptic
Copy link

What would you like to see added to MatNWB?

Analogous to pynwb/h5py support of ROS3 HDF5 driver mode https://pynwb.readthedocs.io/en/stable/tutorials/advanced_io/streaming.html#streaming-method-1-ros3

I remember some folks talking about it but failed to find any issue, so decided to report

Is your feature request related to a problem?

No response

What solution would you like?

A solution similar to pynwb

Do you have any interest in helping implement the feature?

No.

Code of Conduct

@bendichter
Copy link
Contributor

bendichter commented Nov 4, 2022

Thanks for opening this issue! In fact, this is possible to do, and you are right this should be a tutorial in MatNWB.

MATLAB has their own version of this. See the convo on the DANDI helpdesk here: dandi/helpdesk#59.

You need to make sure your credentials as set up correctly, and then you can just pass an s3 path to nwbRead. The problem is that this is quite slow. Last time I ran this on my local computer reading a file took 938 seconds. It will probably depend a lot on the file though and will probably be faster on DANDI Hub. I just tried this out but MATLAB isn't working on the hub for me: dandi/dandi-hub#42

@bendichter
Copy link
Contributor

bendichter commented Nov 4, 2022

Just tested it locally.

>> s3 = 's3://dandiarchive/blobs/284/eb3/284eb346-0bc5-42a6-9b33-268e6b0b0bde'
>> tic; nwbRead(s3); toc;
Elapsed time is 20.215386 seconds.

I think > 20 seconds to open a file is too long to really be practical. Just opening it without any construction of the NWB objects is much more reasonable:

>> tic; H5F.open(s3); toc;
Elapsed time is 0.247859 seconds.

which makes me think that matnwb on DANDI Hub might be someone reasonable. I'll give that a shot once it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants