Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for oblique and axis projection splitters. #28

Open
jheiko1 opened this issue Feb 10, 2020 · 1 comment · May be fixed by #33
Open

Tests for oblique and axis projection splitters. #28

jheiko1 opened this issue Feb 10, 2020 · 1 comment · May be fixed by #33

Comments

@jheiko1
Copy link

jheiko1 commented Feb 10, 2020 •
edited
Loading

Additions to current tests

  • Add test for values to both splitters (currently just impurity)
    New tests
  • Multiple outputs
  • Ensure same result when running the same initial random state multiple times
  • Different results with different random states
@bdpedigo
Copy link

Need more info. Which splitters, what are the experiments you are going to run in order to verify they are working correctly. Can you explain why writing them in Python is necessary?

@jheiko1 jheiko1 changed the title Create pure python implementation of splitters Tests oblique and axis projection splitters. Feb 16, 2020
@jheiko1 jheiko1 changed the title Tests oblique and axis projection splitters. Tests for oblique and axis projection splitters. Feb 24, 2020
@morgsmss7 morgsmss7 linked a pull request Mar 23, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Shared Weights + Tests NeuroDataDesign/scikit-learn
2 participants
@bdpedigo @jheiko1