Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Python ONNX parser for Split node #758

Open
MatthewDaggitt opened this issue Feb 17, 2024 · 3 comments
Open

Bug in Python ONNX parser for Split node #758

MatthewDaggitt opened this issue Feb 17, 2024 · 3 comments
Labels

Comments

@MatthewDaggitt
Copy link
Collaborator

MatthewDaggitt commented Feb 17, 2024

Found another bug in the Python ONNX parser which documenting in case of failure to merge the C++ parser. The code doesn't query the num_outputs attribute, and treats incorrectly gets split as an attribute when it should be an input node. See https://github.com/onnx/onnx/blob/main/docs/Operators.md#Split for details.

It also unnecessarily recreates a whole set of new output variables.

Again, not planning to fix myself as the C++ implementation will be correct.

@akshaydr
Copy link

I am facing similar issue. Importing Split_18 from onnx.reference.ops._op_list fails. Is there a quick fix?

@MatthewDaggitt
Copy link
Collaborator Author

That doesn't sound like the same issue. Sounds like you have the wrong version of ONNX installed. Are 1.15.0 or higher?

@akshaydr
Copy link

You are correct. I had lower ONNX version. Thanks for a quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants