Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bingo card position interface ideas #79

Closed
UnlucksMcGee opened this issue Nov 2, 2021 · 2 comments
Closed

Bingo card position interface ideas #79

UnlucksMcGee opened this issue Nov 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@UnlucksMcGee
Copy link
Contributor

UnlucksMcGee commented Nov 2, 2021

These are my ideas for the bingo card positioning interface. If you approve these suggestions, then I could maybe work on a pull request with the changes.

1. Simplify adjustment interface

The current Bingo card adjustment menu looks like this:
image

My suggestion is to simplify it, and only have "shift left", "reset" and "shift right" buttons.
image

This makes the interface clean (don't need to add a ton of options for all the positions), makes it more intuitive for the user.

2. Change card_pos values

The bingo.card_pos scoreboard can be adjusted such that the card positions are ordered in terms of their screen position from left to right. (This makes the above interface suggestion simpler to implement.)

e.g. The default position can be 0, then when you click left, it decrements the score to -1 which would represent the "left edge (gui 4)" position, followed by "left edge (gui 3)" and so on.

e.g. If you click right, it increments the score to 1 which is "next to hotbar (right)", then 2 would represent "next to attack indicator" and so on.

3. Add new (or replace default) card position

I suggest adding this additional card position (or maybe replacing the current default with it?).
This new position has a gap between the hotbar and the bingo card making it look less cramped against the hotbar/time.
The width of the gap is equal to the space between the hotbar and offhand slot to keep it symmetrical.

The current default is shown in red, with my suggestion in green:
image

@NeunEinser
Copy link
Owner

which would represent the "left edge (gui 4)" position, followed by "left edge (gui 3)" and so on.

Left/right edge is disabled because it doesn't work properly -- I need information about screen resolution as well, that what you saw in the function foolishly assumed it's only defendant on GUI size and tested with my 1080p monitor. There are even GUI sizes that only become available with a higher res monitor and technically there is no limit on GUI size either.

And yeah, I still think the best solution is to incorporate the card into the custom hud system, as this would also allow to set other components in spots which are currently only available for the card.

I am aware that the current interface for the card isn't ideal right now, but it's the best option without major changes for now (minimum required change is to prompt the player for gui size, screen resolution and attack indicator in a nice non-annoying and skipable way).

@NeunEinser NeunEinser added the enhancement New feature or request label Nov 2, 2021
@NeunEinser
Copy link
Owner

I created #85 now for refactoring the card as HUD component.
Having other components in that slot requires a margin anyways, so this is also included in there.

Thus this issue is redundant now.

@NeunEinser NeunEinser closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants