Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorized code output flag in CLI #752

Merged
merged 4 commits into from
May 16, 2023

Conversation

tinoh9
Copy link
Contributor

@tinoh9 tinoh9 commented May 3, 2023

Based on #716, the purpose of this PR is to add a flag which let users enable colorized code output. Please kindly let me know if I need to modify something.

cmd/juno/juno.go Outdated Show resolved Hide resolved
utils/log.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak force-pushed the tinoh9/color-flag branch from 2abfd05 to 663e24a Compare May 12, 2023 07:41
@omerfirmak omerfirmak requested a review from kirugan as a code owner May 12, 2023 07:41
@omerfirmak
Copy link
Contributor

omerfirmak commented May 12, 2023

Please fix the CI errors

@omerfirmak
Copy link
Contributor

omerfirmak commented May 15, 2023

@tinoh9 there are remaining CI errors. Make sure you can run make test locally without any errors

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.03 ⚠️

Comparison is base (63b7bd9) 76.99% compared to head (fcd8522) 76.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   76.99%   76.96%   -0.03%     
==========================================
  Files          44       44              
  Lines        4229     4233       +4     
==========================================
+ Hits         3256     3258       +2     
- Misses        773      775       +2     
  Partials      200      200              
Impacted Files Coverage Δ
node/node.go 7.85% <50.00%> (ø)
cmd/juno/juno.go 56.89% <100.00%> (+0.75%) ⬆️
utils/log.go 74.07% <100.00%> (+1.52%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@omerfirmak omerfirmak force-pushed the tinoh9/color-flag branch from 946b49d to ca702d6 Compare May 15, 2023 09:18
@omerfirmak omerfirmak force-pushed the tinoh9/color-flag branch from ca702d6 to fcd8522 Compare May 16, 2023 11:27
@omerfirmak omerfirmak merged commit 66fdc74 into NethermindEth:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants