-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colorized code output flag in CLI #752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinoh9
requested review from
IronGauntlets,
joshklop,
omerfirmak,
jelilat and
wojciechos
as code owners
May 3, 2023 09:48
omerfirmak
reviewed
May 3, 2023
joshklop
reviewed
May 3, 2023
omerfirmak
force-pushed
the
tinoh9/color-flag
branch
from
May 12, 2023 07:41
2abfd05
to
663e24a
Compare
omerfirmak
approved these changes
May 12, 2023
Please fix the CI errors |
@tinoh9 there are remaining CI errors. Make sure you can run |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 76.99% 76.96% -0.03%
==========================================
Files 44 44
Lines 4229 4233 +4
==========================================
+ Hits 3256 3258 +2
- Misses 773 775 +2
Partials 200 200
☔ View full report in Codecov by Sentry. |
omerfirmak
force-pushed
the
tinoh9/color-flag
branch
from
May 15, 2023 09:18
946b49d
to
ca702d6
Compare
IronGauntlets
approved these changes
May 16, 2023
omerfirmak
force-pushed
the
tinoh9/color-flag
branch
from
May 16, 2023 11:27
ca702d6
to
fcd8522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #716, the purpose of this PR is to add a flag which let users enable colorized code output. Please kindly let me know if I need to modify something.