Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make colour codes configurable #716

Closed
jelilat opened this issue Apr 4, 2023 · 4 comments
Closed

Make colour codes configurable #716

jelilat opened this issue Apr 4, 2023 · 4 comments
Assignees
Labels
CLI Command line interface Good first issue Good for newcomers

Comments

@jelilat
Copy link
Contributor

jelilat commented Apr 4, 2023

We should add a flag that lets users enable colour codes.

@jelilat jelilat added the CLI Command line interface label Apr 4, 2023
@IronGauntlets IronGauntlets added the Good first issue Good for newcomers label Apr 4, 2023
@tinoh9
Copy link
Contributor

tinoh9 commented Apr 26, 2023

Hi, can I try this one? Thanks.

@omerfirmak
Copy link
Contributor

Hi @tinoh9, sure. We would be glad:) Assigning it to you.

@tinoh9
Copy link
Contributor

tinoh9 commented May 2, 2023

Should I create a new .go file which stores all color variables, and import it to all relevant string outputs that need to be colorized in CLI?

@omerfirmak
Copy link
Contributor

Should I create a new .go file which stores all color variables, and import it to all relevant string outputs that need to be colorized in CLI?

That sounds too complicated, see the PR that disabled the color output. It should as simple as just passing the old value EncodeLevel function there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command line interface Good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants