Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing expression in parser #548

Closed
har777 opened this issue Jul 17, 2024 · 2 comments · Fixed by #625
Closed

Missing expression in parser #548

har777 opened this issue Jul 17, 2024 · 2 comments · Fixed by #625
Assignees
Labels
bug Something isn't working Duration: few days Will take a few days and might need feedback from several people help wanted Extra attention is needed

Comments

@har777
Copy link
Contributor

har777 commented Jul 17, 2024

Expressions of the kind cast(1, felt) seem to be missing from the parser.

Sample file which can fail: https://github.com/lambdaclass/cairo-vm/blob/main/cairo_programs/bitand_hint.cairo

@TAdev0 TAdev0 added bug Something isn't working help wanted Extra attention is needed Duration: few days Will take a few days and might need feedback from several people labels Jul 23, 2024
@HumbertoTM10
Copy link

Hi @har777 where do you need to add exactly those expressions? In what contexts should these expressions be allowed or expected?

@cicr99
Copy link
Contributor

cicr99 commented Aug 16, 2024

Hey @HumbertoTM10 sorry for the late reply. We found some other expressions apart from the one in this issue that were not supported by our parser, when they should have been. Solving the problem implied a big modification on the hint-reference-parser codebase. PR #625 should be fixing them already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Duration: few days Will take a few days and might need feedback from several people help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants