Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set env var BD_USER #1218

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Set env var BD_USER #1218

merged 1 commit into from
Jun 22, 2024

Conversation

jzhuge
Copy link
Contributor

@jzhuge jzhuge commented Jun 6, 2024

@jzhuge
Copy link
Contributor Author

jzhuge commented Jun 6, 2024

@bhou2 Could you show me where to add unit test?

@bhou2
Copy link
Contributor

bhou2 commented Jun 6, 2024

@jzhuge The unit tests can be added to this file: https://sourcegraph.netflix.net/stash.corp.netflix.com/GM/genie@6bad017d8078c94e80d6c6fe8abd693910bf55cf/-/blob/genie-web/src/test/groovy/com/netflix/genie/web/agent/launchers/impl/TitusAgentLauncherImplSpec.groovy

@bhou2
Copy link
Contributor

bhou2 commented Jun 21, 2024

LGTM. Thanks for the update.

@bhou2 bhou2 self-requested a review June 21, 2024 18:03
@jzhuge jzhuge merged commit 3b2df6a into Netflix:master Jun 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhou2 bhou2 bhou2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzhuge @bhou2