add upstream security information pass thru mechanism #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
=========================================
Coverage 90.74% 90.74%
- Complexity 3803 3809 +6
=========================================
Files 467 467
Lines 14963 14968 +5
Branches 1071 1071
=========================================
+ Hits 13578 13583 +5
Misses 909 909
Partials 476 476
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bhou2
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a way for the clients that use the genie java-client to pass through customized security information.
Ideally, the security or authorization should be handled by the framework rather than app logic. However, due to the fact that the upstream clients of genie normally are some type of scheduler that runs job on user's behalf. The job authorization may need information beyond the client's own identity.