Java 17 Support

[Fhat]

Hi, I'm getting issues starting up a Java worker running on Spring Boot 2.7.x and Java 17 (NoClassDef etc), so am presuming it is not currently supported. With Java 11 it works fine. I spotted this issue: #3051, which said it was coming in Q3 2022, so I'm not sure whether: a) support was added and I'm doing wrong, or b) it's still currently unsupported

If I'm not doing something wrong and Java 17 isn't currently supported, is adding support to the worker library something that is still being progressed?

Thanks a lot!

Replies

[davidfrankoproceedy]

Hi @Fhat,

we are using Java workers with Java 17 and there seems to be no problem. Though note we are using Spring Boot 3. Regardless, it does not seem there is a problem with Java 17. Perhaps it's some problem with your dependencies?

Here is our pom.xml (using Maven), hope it helps:

    <properties>
        <version.feign.json>12.1</version.feign.json>
        <version.feign.springcloud>4.0.0</version.feign.springcloud>
        <version.netflix.conductor>3.13.2</version.netflix.conductor>

        <java.version>17</java.version>
        <maven.compiler.source>17</maven.compiler.source>
        <maven.compiler.target>17</maven.compiler.target>

        <spring-boot.version>3.0.2</spring-boot.version>
        <micrometer-tracing.version>1.0.1</micrometer-tracing.version>
        <lombok.version>1.18.24</lombok.version>
        <version.mapstruct>1.5.1.Final</version.mapstruct>
        <version.lombok-mapstruct>0.2.0</version.lombok-mapstruct>
    </properties>

    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>io.micrometer</groupId>
                <artifactId>micrometer-tracing-bom</artifactId>
                <version>${micrometer-tracing.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>

            <dependency>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-dependencies</artifactId>
                <version>${spring-boot.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>


    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-actuator</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-devtools</artifactId>
            <scope>runtime</scope>
            <optional>true</optional>
        </dependency>

        <dependency>
            <groupId>org.projectlombok</groupId>
            <artifactId>lombok</artifactId>
            <optional>true</optional>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-test</artifactId>
            <scope>test</scope>
        </dependency>

        <dependency>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-core</artifactId>
        </dependency>

        <dependency>
            <groupId>org.mapstruct</groupId>
            <artifactId>mapstruct</artifactId>
            <version>${version.mapstruct}</version>
        </dependency>

        <dependency>
            <groupId>org.projectlombok</groupId>
            <artifactId>lombok-mapstruct-binding</artifactId>
            <version>${version.lombok-mapstruct}</version>
        </dependency>

        <dependency>
            <groupId>io.micrometer</groupId>
            <artifactId>micrometer-tracing</artifactId>
        </dependency>

        <dependency>
            <groupId>io.micrometer</groupId>
            <artifactId>micrometer-tracing-bridge-brave</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-context-support</artifactId>
        </dependency>

        <dependency>
            <groupId>com.google.code.gson</groupId>
            <artifactId>gson</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-openfeign</artifactId>
            <version>${version.feign.springcloud}</version>
        </dependency>

        <dependency>
            <groupId>io.github.openfeign</groupId>
            <artifactId>feign-gson</artifactId>
            <version>${version.feign.json}</version>
        </dependency>

        <dependency>
            <groupId>org.apache.commons</groupId>
            <artifactId>commons-lang3</artifactId>
        </dependency>

        <!-- Netflix Conductor -->
        <dependency>
            <groupId>com.netflix.conductor</groupId>
            <artifactId>conductor-client</artifactId>
            <version>${version.netflix.conductor}</version>
            <exclusions>
                <exclusion>
                    <groupId>org.apache.logging.log4j</groupId>
                    <artifactId>log4j-slf4j-impl</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>com.netflix.eureka</groupId>
                    <artifactId>eureka-client</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

        <!-- Overriding vulnerable version from conductor-client  -->
        <dependency>
            <groupId>com.netflix.eureka</groupId>
            <artifactId>eureka-client</artifactId>
            <version>2.0.0</version>
        </dependency>

        <dependency>
            <groupId>com.netflix.conductor</groupId>
            <artifactId>conductor-common</artifactId>
            <version>${version.netflix.conductor}</version>
            <exclusions>
                <exclusion>
                    <groupId>org.apache.logging.log4j</groupId>
                    <artifactId>log4j-slf4j-impl</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

        <dependency>
            <groupId>javax.ws.rs</groupId>
            <artifactId>javax.ws.rs-api</artifactId>
            <version>2.1.1</version>
        </dependency>
    </dependencies>

[Fhat]

Hi @davidfrankoproceedy, thanks for the response. When I have some time to pick this back up again I'll have a play - I'll try with Spring Boot 3. Overriding that eureka-client version looks interesting too, as iirc the conductor dependencies had a dependency clash and I think the path to one of the clashing versions was through eureka-client. Definitely useful to have the data point that the problem is on my end though, thanks!

[exelon-admin]

Hi @davidfrankoproceedy ,
I am having a similar issue with Spring boot 3 using your netflix conductor dependencies. I am getting the following exception on startup.
...Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.netflix.conductor.client.http.WorkflowClient]: Factory method 'getWorkflowClient' threw exception with message: ClassCastException: attempting to castjar:file:/Users/user/.gradle/caches/modules-2/files-2.1/javax.ws.rs/javax.ws.rs-api/2.1.1/d3466bc9321fe84f268a1adb3b90373fc14b0eb5/javax.ws.rs-api-2.1.1.jar!/javax/ws/rs/ext/RuntimeDelegate.class to jar:file:/Users/user/.gradle/caches/modules-2/files-2.1/javax.ws.rs/javax.ws.rs-api/2.1.1/d3466bc9321fe84f268a1adb3b90373fc14b0eb5/javax.ws.rs-api-2.1.1.jar!/javax/ws/rs/ext/RuntimeDelegate.class at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:171) ~[spring-beans-6.0.9.jar:6.0.9] SimpleInstantiationStrategy.java:171 at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:655) ~[spring-beans-6.0.9.jar:6.0.9] ConstructorResolver.java:655 ... 124 common frames omitted Caused by: java.lang.LinkageError: ClassCastException: attempting to castjar:file:/Users/user/.gradle/caches/modules-2/files-2.1/javax.ws.rs/javax.ws.rs-api/2.1.1/d3466bc9321fe84f268a1adb3b90373fc14b0eb5/javax.ws.rs-api-2.1.1.jar!/javax/ws/rs/ext/RuntimeDelegate.class to jar:file:/Users/user/.gradle/caches/modules-2/files-2.1/javax.ws.rs/javax.ws.rs-api/2.1.1/d3466bc9321fe84f268a1adb3b90373fc14b0eb5/javax.ws.rs-api-2.1.1.jar!/javax/ws/rs/ext/RuntimeDelegate.class at javax.ws.rs.ext.RuntimeDelegate.findDelegate(RuntimeDelegate.java:125) ~[javax.ws.rs-api-2.1.1.jar:2.1.1] RuntimeDelegate.java:125 at javax.ws.rs.ext.RuntimeDelegate.getInstance(RuntimeDelegate.java:97) ~[javax.ws.rs-api-2.1.1.jar:2.1.1]

Here is my bean:
`@Bean
@ConditionalOnMissingBean
public WorkflowClient getWorkflowClient() {

    WorkflowClient workflowClient = new WorkflowClient();
    workflowClient.setRootURI(env.getConductorServerUri());

    return workflowClient;
}`

And have the following in my implementing class
@Autowired private WorkflowClient wfClient;

Thanks