Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DefaultFactories.TRUST_ALL causes SelfSignedSSLEngineFactory to Error on Certain Systems. #233

Closed
AndrewReitz opened this issue Sep 15, 2014 · 0 comments
Milestone

Comments

@AndrewReitz
Copy link
Contributor

On systems that don't have OpenJdkSelfSignedCertGenerator or BouncyCastleSelfSignedCertGenerator available to them (for example Android), it will error out when using DefaultFactories.TRUST_ALL, even though those are requirements for DefaultFactories.SELF_SIGNED.

This could be solved by having the two engines SELF_SIGNED and TRUST_ALL be lazy loaded, so that they are only instantiated when needed. Let me know how you would like to proceed with this and I can do the work and provide a PR.

Also a side note, shouldn't these by final?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants