Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the 'Contains' operator #410

Merged
merged 3 commits into from
Oct 9, 2013

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Sep 26, 2013

Hi, I implemented the Contains operator #31. I saw the discussion about the distinct operator #395, so I did not implement the comparator override. Please take a look. Thanks!

@cloudbees-pull-request-builder

RxJava-pull-requests #315 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #316 SUCCESS
This pull request looks good

@samuelgruetter
Copy link
Contributor

@cloudbees-pull-request-builder glad to see you work again ;-)

@zsxwing Nice. I also think that we don't need an overload with a comparator, because one can simply use exists instead:

o.exists(new Func1<T, Boolean>() {
    public Boolean call(T a) {
        // check if a is "equal" to the desired element using custom comparison strategy
    }
});

benjchristensen added a commit that referenced this pull request Oct 9, 2013
Implemented the 'Contains' operator
@benjchristensen benjchristensen merged commit 848a4e0 into ReactiveX:master Oct 9, 2013
@zsxwing zsxwing deleted the contains branch October 9, 2013 07:39
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Implemented the 'Contains' operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants