Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Interval and Sample default Scheduler #394

Merged
merged 1 commit into from
Sep 19, 2013

Conversation

benjchristensen
Copy link
Member

Change to use built-in thread-pools rather than creating a new Executor on each invocation.
The built-in ones are shared across all operators, have threads ready, are marked as daemon threads so don't prevent system shutdown, and are named for clarity when looking at thread dumps and debuggers.

This fixes #388

Change to use built-in thread-pools rather than creating a new Executor on each invocation.
The built-in ones are shared across all operators, have threads ready, are marked as daemon threads so don't prevent system shutdown, and are named for clarity when looking at thread dumps and debuggers.
benjchristensen added a commit that referenced this pull request Sep 19, 2013
Change Interval and Sample default Scheduler
@benjchristensen benjchristensen merged commit cd748e8 into ReactiveX:master Sep 19, 2013
@benjchristensen benjchristensen deleted the issue-388 branch September 19, 2013 05:07
@cloudbees-pull-request-builder

RxJava-pull-requests #293 FAILURE
Looks like there's a problem with this pull request

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Change Interval and Sample default Scheduler
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…e of a Co… (ReactiveX#394)

* Issue ReactiveX#280: CircuitBreaker and Retry should forward the cause of a CompletionException to the exceptionPredicate so that you can use CircuitBreakerConfig::ingoreExceptions and RetryConfig::ingoreExceptions correctly.

* Removed not needed try/catch in AsyncRetryBlock.run. Retry should not retry when the CompletionStage cannot even be supplied. This is mostly a developer mistake and the backend is not even called.

* Removed not needed try/catch in AsyncRetryBlock.run. Retry should not retry when the CompletionStage cannot even be supplied. This is mostly a developer mistake and the backend is not even called.

* Added a new Retry test to test the decoration of CompletionStage.

* Added a new Retry test to test the decoration of CompletionStage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants