Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxScala: Fix errors in Completeness.scala and also improve it #1564

Merged
merged 2 commits into from
Aug 11, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Aug 11, 2014

/cc @headinthebox, @samuelgruetter

@cloudbees-pull-request-builder

RxJava-pull-requests #1476 FAILURE
Looks like there's a problem with this pull request

@samuelgruetter
Copy link
Contributor

LGTM

@samuelgruetter
Copy link
Contributor

except one detail: in the CompletenessTest, replace

Note:
*    This table contains both static methods and instance methods.
*    If a signature is too long, move your mouse over it to get the full signature.

by

Note:

*    This table contains both static methods and instance methods.
*    If a signature is too long, move your mouse over it to get the full signature.

because apparently, that blank line is needed for the parser to recognize the bullet points.

@zsxwing
Copy link
Member Author

zsxwing commented Aug 11, 2014

@samuelgruetter done

@cloudbees-pull-request-builder

RxJava-pull-requests #1477 FAILURE
Looks like there's a problem with this pull request

benjchristensen added a commit that referenced this pull request Aug 11, 2014
RxScala: Fix errors in Completeness.scala and also improve it
@benjchristensen benjchristensen merged commit affa3ad into ReactiveX:master Aug 11, 2014
@zsxwing zsxwing deleted the rxscala-completeness branch August 12, 2014 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants