Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal Hystrix counters with HdrHistogram #698

Closed
mattrjacobs opened this issue Feb 24, 2015 · 4 comments
Closed

Replace internal Hystrix counters with HdrHistogram #698

mattrjacobs opened this issue Feb 24, 2015 · 4 comments

Comments

@mattrjacobs
Copy link
Contributor

HdrHistogram implements the same functionality as the internal Hystrix counters, but with better resolution/space/speed guarantees.

I'm not sure which APIs would change as a result of this switch yet, but it should be fairly minimal.

@mattrjacobs mattrjacobs modified the milestone: 1.4.2 Mar 3, 2015
@mattrjacobs mattrjacobs modified the milestones: Hystrix-core Bugfixes, Hystrix-core Features Mar 27, 2015
@mattrjacobs
Copy link
Contributor Author

#779 replaced AtomicIntegerArrays with HdrHistogram (specifically IntCountsHistogram) for latency metrics

@mattrjacobs
Copy link
Contributor Author

In the course of doing this upgrade, I inadvertantly introduced thread safety issues and a memory leak. I rolled back this change for now, while I consider how to reintroduce it.

@mattrjacobs mattrjacobs modified the milestones: Hystrix-core Features, 1.5.x Aug 3, 2015
@mattrjacobs
Copy link
Contributor Author

#843 provides a facility to vary metrics collection behavior. That will make this feature easier to implement. My current plan is to introduce this as an option in 1.5.x, and hopefully receive feedback (from internal testing and external users) to determine if it should be the default going forward.

@mattrjacobs
Copy link
Contributor Author

Closing in favor of more-general #943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant