Why error logging in RequestBatch?

[azpeters]

Elsewhere in Hystrix code, error logging has been left to the client and has been in the Hystrix code itself at debug level. However, in RequestBatch, there is logging at error level, so I'm seeing dual logging of very long stack traces in my logs (since I, too, am logging). Is there a reason that error logging happens in this class, even though it doesn't elsewhere?

Line I'm looking at:

Hystrix/hystrix-core/src/main/java/com/netflix/hystrix/collapser/RequestBatch.java

Line 124 in 62ac93f

logger.error("Exception mapping responses to requests.", e);

[benjchristensen]

Doesn't look like a good reason, just an oversight. It can be changed to debug.

[mattrjacobs]

@azpeters This change is in #374. Any other problematic logging you see?