Set maximumSize using @HystrixCommand annotation

[ilyas-keser]

It is not possible to set the maximumSize using the HystrixCommand annotation. Example:

  @HystrixCommand(ignoreExceptions = MyException.class,
    threadPoolProperties = {
      @HystrixProperty(name = "coreSize", value = "20"),
      @HystrixProperty(name = "maximumSize", value = "25"),
      @HystrixProperty(name = "allowMaximumSizeToDivergeFromCoreSize", value = "true")
  })
  public MyPerson getMyPerson(...)

Hystrix version: 1.5.11

Exception:

Caused by: java.lang.IllegalArgumentException: unknown thread pool property: maximumSize
	at com.netflix.hystrix.contrib.javanica.conf.HystrixPropertiesManager.initializeProperties(HystrixPropertiesManager.java:125)
	at com.netflix.hystrix.contrib.javanica.conf.HystrixPropertiesManager.initializeThreadPoolProperties(HystrixPropertiesManager.java:108)
	at com.netflix.hystrix.contrib.javanica.command.GenericSetterBuilder.build(GenericSetterBuilder.java:81)

[mattrjacobs]

@dmgcodevil Any cycles to work on this?

@ilyas-keser Any interest in submitting a PR for this functionality?

[dmgcodevil]

PR: #1572

[ilyas-keser]

@dmgcodevil Is it possible to set allowMaximumSizeToDivergeFromCoreSize? The maximumSize setting only takes effect if you also set the allowMaximumSizeToDivergeFromCoreSize setting.

[mattrjacobs]

@ilyas-keser I just submitted #1584

[ilyas-keser]

@mattrjacobs Thanks!

[dmgcodevil]

we can close