Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard and Dollar sign #100

Closed
de-raphi opened this issue Feb 8, 2013 · 2 comments
Closed

Dashboard and Dollar sign #100

de-raphi opened this issue Feb 8, 2013 · 2 comments

Comments

@de-raphi
Copy link

de-raphi commented Feb 8, 2013

If a HystrixCommand-name (also GroupKey) contains a dollar sign ($) the Dashboard does not display the diagram correctly.

e.g.:
data: {"type":"HystrixCommand","name":"$DomInfo.isFreeFast" ..... }

@benjchristensen
Copy link
Contributor

Our 'invalid character' cleanup apparently isn't good enough:

https://github.com/Netflix/Hystrix/blob/master/hystrix-dashboard/src/main/webapp/components/hystrixCommand/hystrixCommand.js#L91
https://github.com/Netflix/Hystrix/blob/master/hystrix-dashboard/src/main/webapp/components/hystrixThreadPool/hystrixThreadPool.js#L86

I have avoided making the regex only accept characters/numbers because I want the full UTF8 character-set to be supported for international usage. That's why I've only stripped bad characters as I have found them.

If you have the time to take a look at how to improve those 2 lines of code above to fix this (and any other invalid characters you know of) I'd appreciate the help.

@ogafosir
Copy link

ogafosir commented Mar 7, 2013

Looks like spaces isn't a good idea either (atleast in ThreadPoolName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants