Remove the topology parameter of feature gates in csi-provisioner

[ysakashita]

Describe the solution you'd like
I would like to remove the topology parameter of the feature gate (--feature-gates=Topology=True) for csi-provisioner.
The parameter was already GA in csi-provisioner.

The csi-provisioner in Trident puts the bellow warning message in the log.

I0704 07:52:52.326573       1 feature_gate.go:243] feature gates: &{map[Topology:true]}
W0704 07:52:52.326483       1 feature_gate.go:235] Setting GA feature gate Topology=true. It will be removed in a future release.

Describe alternatives you've considered

(Maybe) trident can controle to ignore the warning message for it.
However, it’s unnatural and not easy way.
So I believe that removing the parameter from the csi-provisioner is a natural way.

Additional context

Please see the following issue.

• mark Topology featuregate as GA kubernetes-csi/external-provisioner#516
  • https://github.com/kubernetes-csi/external-provisioner/blob/release-2.1/pkg/features/features.go#L38

[clintonk]

Hello, @ysakashita-san, thank you for this suggestion.

Despite the Topology feature of the external-provisioner sidecar reaching GA status, the documentation still indicates that setting --feature-gates=Topology=true is necessary to use the sidecar's Topology feature. To be certain, I have built & run the sidecar with and without the Topology feature gate flag and confirmed that without it, the Topology feature is inactive.

Also, please note that Trident's use of CSI Topology is already dynamic. Trident inspects the Kubernetes node objects and enables the sidecar's Topology feature if any of the nodes contain the standard topology labels. It seems we must continue that behavior with latest versions of the sidecar.

The warning message you noted is being logged from a library imported by the sidecar, so we have no way to suppress that. If anything changes in a future version of the sidecar, we can reevaluate then. Again, thank you for your input.

[gnarl]

Closing this issue per @clintonk's research on the issue.