[New Resource]: Ethernet Port #334

acch · 2024-11-13T10:46:56Z

Adds ability to create ethernet ports (VLAN / LAG).

Closes #304.

Acceptance tests pass:

TF_ACC=1 go test ./internal/provider/networking/network_ethernet_port_resource_test.go -v
=== RUN   TestAccNetworkEthernetPortResource
--- PASS: TestAccNetworkEthernetPortResource (16.33s)
PASS
ok      command-line-arguments  16.338s

Example Terraform Configurations:

// sample LAG with required properties
resource "netapp-ontap_port" "lag" {
  cx_profile_name = ...

  broadcast_domain = {
    ipspace = "Default"
    name    = "bd1"
  }

  node = {
    name = "node1"
  }

  type = "lag"
  lag = {
    distribution_policy = "mac"
    member_ports = [ "e0b", "e0c" ]
    mode = "singlemode"
  }
}

// sample VLAN with required properties
resource "netapp-ontap_port" "vlan" {
  cx_profile_name = ...

  broadcast_domain = {
    ipspace = "Default"
    name    = "bd2"
  }

  node = {
    name = "node1"
  }

  type = "vlan"
  vlan = {
    base_port = "e0a"
    tag       = 100
  }
}

…resource-example-not-showing-up-correctly-1 fix Doc bug for flexcache

…mes_files New Resource volume files

…m-provider-netapp-ontap into 184-add-lambda-connector

…g-for-resource-ip-route

…ion-is-wrong-for-resource-ip-route 265 docs on prem ontap version is wrong for resource ip route

140 new data source securityroles

go tidy"

Bumps [github.com/hashicorp/terraform-plugin-framework-validators](https://github.com/hashicorp/terraform-plugin-framework-validators) from 0.12.0 to 0.16.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-framework-validators/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework-validators/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework-validators@v0.12.0...v0.16.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework-validators dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/hashicorp/terraform-plugin-framework-validators-0.16.0 Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.12.0 to 0.16.0

Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.34.0 to 2.35.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.34.0...v2.35.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/hashicorp/terraform-plugin-sdk/v2-2.35.0 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.34.0 to 2.35.0

carchi8py

Looks good as well just missing documentation files.

Signed-off-by: Achim Christ <[email protected]>

… methods Signed-off-by: Achim Christ <[email protected]>

Signed-off-by: Achim Christ <[email protected]>

…tes without requiring refresh Signed-off-by: Achim Christ <[email protected]>

Signed-off-by: Achim Christ <[email protected]>

acch · 2025-01-13T10:20:23Z

Thanks @carchi8py for your feedback!

I've manually added the documentation pages in the docs/ directory.

Signed-off-by: Achim Christ <[email protected]>

wenjun666 and others added 30 commits August 19, 2024 15:42

resolve conflict.

ccb165d

Edit config_test.go

a189c09

Merge pull request NetApp#272 from NetApp/271-docs-storage_flexcache_…

d478662

…resource-example-not-showing-up-correctly-1 fix Doc bug for flexcache

Merge pull request NetApp#268 from NetApp/5-new-resource-storage_volu…

dcaf366

…mes_files New Resource volume files

security login message data source

82f7a7d

add docs

423fa2e

update doc and fix lint

bb27335

update based on the review comments

ad691eb

apply/sync fix issue 264

1e8d67c

security login message data source

e31aeb9

Edit provider schema.

6402ef9

looks like a cp a random file name on to a variable

90c3c5d

Edit Schema description.

a057d52

Merge branch 'integration/main' of https://github.com/NetApp/terrafor…

44182ac

…m-provider-netapp-ontap into 184-add-lambda-connector

Remove unused comments.

6c93776

Edit CHANGELOG.md

b9032d5

resolve conflict.

1336f97

Merge branch 'stable-1.1' into 265-docs-on-prem-ontap-version-is-wron…

8c8f80b

…g-for-resource-ip-route

Add new resource security role.

b3b97f0

Remove commented code.

de98a96

Move report error inside err if statement.

2bd5d6c

add new resource

17dce54

Edit security_roles.md

80bb25a

add docs

b49671e

new resource qos policies

bca70e2

Merge pull request NetApp#273 from NetApp/265-docs-on-prem-ontap-vers…

874094c

…ion-is-wrong-for-resource-ip-route 265 docs on prem ontap version is wrong for resource ip route

Merge pull request NetApp#226 from NetApp/140-new-resource-securityroles

66968a8

140 new data source securityroles

Edit CHANGELOG.md

24d3ed4

Added changes.

67ab94b

Edit generate_docs.py

2ba2f52

Chris Archibald and others added 6 commits January 6, 2025 09:04

go tidy"

ea5cf87

Merge pull request NetApp#366 from NetApp/tidy

b756460

go tidy"

Merge pull request NetApp#355 from NetApp/dependabot/go_modules/githu…

f087a67

…b.com/hashicorp/terraform-plugin-framework-validators-0.16.0 Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.12.0 to 0.16.0

Merge pull request NetApp#362 from NetApp/dependabot/go_modules/githu…

0eaabad

…b.com/hashicorp/terraform-plugin-sdk/v2-2.35.0 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.34.0 to 2.35.0

carchi8py added the New Data Source New Request for an ONTAP Data source label Jan 6, 2025

carchi8py requested changes Jan 6, 2025

View reviewed changes

acch added 16 commits January 13, 2025 09:35

feat: add ethernet_port data source

0f1e0bb

Signed-off-by: Achim Christ <[email protected]>

fix: rename data source to port

8594731

Signed-off-by: Achim Christ <[email protected]>

feat: add ports data source

e232a1b

Signed-off-by: Achim Christ <[email protected]>

feat: use Terraform Set Type instead of Go built-in slice

17f1d38

Signed-off-by: Achim Christ <[email protected]>

feat: add port resource - create method

916b583

Signed-off-by: Achim Christ <[email protected]>

feat: consistent error handling

88a7d7e

Signed-off-by: Achim Christ <[email protected]>

feat: add LAG examples

3349207

Signed-off-by: Achim Christ <[email protected]>

feat: add port resource - delete method

af6ae79

Signed-off-by: Achim Christ <[email protected]>

fix: correct 'port' resource for type LAG

78f9781

Signed-off-by: Achim Christ <[email protected]>

feat: add remaining attribute description

974a99e

Signed-off-by: Achim Christ <[email protected]>

feat: finalize data models with remaining attributes

7f90616

Signed-off-by: Achim Christ <[email protected]>

feat: add acceptance tests for 'port' resource - read, create, delete…

ec02f1e

… methods Signed-off-by: Achim Christ <[email protected]>

feat: add port resource - update method

7d0311a

Signed-off-by: Achim Christ <[email protected]>

feat: improve create method so that it populates all resource attribu…

c923d9b

…tes without requiring refresh Signed-off-by: Achim Christ <[email protected]>

feat: add port resource - import method

1378b6f

Signed-off-by: Achim Christ <[email protected]>

chore: change cx_profile_name for consistency with other examples

e9b8812

Signed-off-by: Achim Christ <[email protected]>

acch force-pushed the 304-ethernet-port-resource branch from 2ca8f64 to 957f0de Compare January 13, 2025 10:18

acch requested a review from carchi8py January 13, 2025 10:22

feat: add port documentation

9a217dd

Signed-off-by: Achim Christ <[email protected]>

acch force-pushed the 304-ethernet-port-resource branch from 957f0de to 9a217dd Compare January 13, 2025 14:56

wenjun666 force-pushed the integration/main branch from 0eaabad to ed4593e Compare January 14, 2025 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Resource]: Ethernet Port #334

[New Resource]: Ethernet Port #334

acch commented Nov 13, 2024 •

edited

Loading

carchi8py left a comment

acch commented Jan 13, 2025

[New Resource]: Ethernet Port #334

Are you sure you want to change the base?

[New Resource]: Ethernet Port #334

Conversation

acch commented Nov 13, 2024 • edited Loading

carchi8py left a comment

Choose a reason for hiding this comment

acch commented Jan 13, 2025

acch commented Nov 13, 2024 •

edited

Loading