[Enhancement]: Add SVM QoS Policy Activation #346

acch · 2024-12-03T18:41:48Z

Adds ability to configure qos_policy parameter of SVMs.

Needs to be a dedicated resource, as creating a QoS Policy scoped to an SVM, and then activating it for the SVM, is a 2-step process. See documentation for details.

Closes #301.

Acceptance tests pass:

$ TF_ACC=1 go test ./internal/provider/svm/svm_qos_policy_activation_resource_test.go -v
=== RUN   TestAccSvmQosPolicyActivationResource
--- PASS: TestAccSvmQosPolicyActivationResource (2.96s)
PASS
ok      command-line-arguments  2.967s

Example Terraform Configuration WIP:

resource "netapp-ontap_svm_qos_policy_activation" "example" { 
  svm = {
    name = "svm01"
  }
  qos_policy = {
    name = "performance_svm01"
  }
}

…quotarules new data source quota rules

…iles

…ample-not-showing-up-correctly-1

…resource-example-not-showing-up-correctly-1 fix Doc bug for flexcache

…mes_files New Resource volume files

…m-provider-netapp-ontap into 184-add-lambda-connector

…g-for-resource-ip-route

…b.com/aws/aws-sdk-go-v2-1.32.6 Bump github.com/aws/aws-sdk-go-v2 from 1.30.3 to 1.32.6

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.27 to 1.28.6. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.27...config/v1.28.6) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/aws/aws-sdk-go-v2/config-1.28.6 Bump github.com/aws/aws-sdk-go-v2/config from 1.27.27 to 1.28.6

Bumps [github.com/aws/aws-sdk-go-v2/service/lambda](https://github.com/aws/aws-sdk-go-v2) from 1.56.3 to 1.69.1. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/lambda/v1.56.3...service/glue/v1.69.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/lambda dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

update to 2.1

…b.com/aws/aws-sdk-go-v2/service/lambda-1.69.1 Bump github.com/aws/aws-sdk-go-v2/service/lambda from 1.56.3 to 1.69.1

Bumps [github.com/hashicorp/terraform-plugin-docs](https://github.com/hashicorp/terraform-plugin-docs) from 0.19.4 to 0.20.1. - [Release notes](https://github.com/hashicorp/terraform-plugin-docs/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-docs/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-docs@v0.19.4...v0.20.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-docs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/hashicorp/terraform-plugin-docs-0.20.1 Bump github.com/hashicorp/terraform-plugin-docs from 0.19.4 to 0.20.1

Bumps [github.com/aws/aws-sdk-go-v2/service/lambda](https://github.com/aws/aws-sdk-go-v2) from 1.69.1 to 1.69.2. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/glue/v1.69.1...service/lambda/v1.69.2) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/lambda dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/aws/aws-sdk-go-v2/service/lambda-1.69.2 Bump github.com/aws/aws-sdk-go-v2/service/lambda from 1.69.1 to 1.69.2

go tidy"

Bumps [github.com/hashicorp/terraform-plugin-framework-validators](https://github.com/hashicorp/terraform-plugin-framework-validators) from 0.12.0 to 0.16.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-framework-validators/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework-validators/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework-validators@v0.12.0...v0.16.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework-validators dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/hashicorp/terraform-plugin-framework-validators-0.16.0 Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.12.0 to 0.16.0

Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.34.0 to 2.35.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.34.0...v2.35.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…b.com/hashicorp/terraform-plugin-sdk/v2-2.35.0 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.34.0 to 2.35.0

carchi8py

So do you expect users to ever pass in the UUID vs name?

When we wrote the Ansible/Terraform modules/resource, we've already assume users would always use name, and we would treat UUID as more of a internal thing. As a user is having both name and UUID useful?

suhasbshekar · 2025-01-07T19:19:21Z

internal/provider/svm/svm_qos_policy_activation_resource.go

+						Optional:            true,
+						Computed:            true,
+					},
+					"id": schema.StringAttribute{


We try to use name all the time, as UUID is not something user friendly, and name itself can handle all functionality, so we have used name in all our Ansible/Terrafrom modules/resources. Unless you have an explicit case, let us know

acch · 2025-01-13T10:57:19Z

There is an advantage of referencing dependent resources by their UUID: the ID is computed by ONTAP API, and hence it's "unknown" during plan-phase. Terraform uses this information when building its dependency graph, and implicitly understands that the dependent resources (e.g. svm or qos_policy) must be created first, before the svm_qos_policy_activation resource.

When referencing resources by their name, Terraform has no indication that one resource depends on the existence of another, and thus needs to be created first. It would attempt to create all resources in parallel (race condition). To prevent this, one would need to add the depends_on meta-argument.

So the following code...

resource "netapp-ontap_qos_policy" "this" {
  name = "test"
}
resource "netapp-ontap_svm_qos_policy_activation" "this" { 
  qos_policy = {
    id = netapp-ontap_qos_policy.this.id
  }
}

...is equivalent to the following code:

resource "netapp-ontap_qos_policy" "this" {
  name = "test"
}
resource "netapp-ontap_svm_qos_policy_activation" "this" { 
  qos_policy = {
    name = "test"
  }
  depends_on = [ netapp-ontap_qos_policy.this ]
}

Hence, I'd suggest to keep the UUID as an optional attribute - do you agree?

Signed-off-by: Achim Christ <[email protected]>

acch · 2025-01-13T14:52:08Z

I've manually added the documentation pages in the docs/ directory. Please let me know what else is missing.

suhasbshekar and others added 30 commits August 13, 2024 16:32

New Resource volume files

f3763d7

Merge pull request NetApp#260 from NetApp/135-new-data-source-storage…

5d073ec

…quotarules new data source quota rules

Merge branch 'integration/main' into 5-new-resource-storage_volumes_f…

00b837b

…iles

remove data_source from file name.

f57ea6b

fix bug missing nodes

2015a2a

fix unit test

10df77e

fix bug

77cdd2c

fixes

7884a2d

initial commit.

9ed5b74

Merge branch 'stable-1.1' into 271-docs-storage_flexcache_resource-ex…

a4a29b3

…ample-not-showing-up-correctly-1

Remove comment.

8822601

resolve conflict.

ccb165d

Edit config_test.go

a189c09

Merge pull request NetApp#272 from NetApp/271-docs-storage_flexcache_…

d478662

…resource-example-not-showing-up-correctly-1 fix Doc bug for flexcache

Merge pull request NetApp#268 from NetApp/5-new-resource-storage_volu…

dcaf366

…mes_files New Resource volume files

security login message data source

82f7a7d

add docs

423fa2e

update doc and fix lint

bb27335

update based on the review comments

ad691eb

apply/sync fix issue 264

1e8d67c

security login message data source

e31aeb9

Edit provider schema.

6402ef9

looks like a cp a random file name on to a variable

90c3c5d

Edit Schema description.

a057d52

Merge branch 'integration/main' of https://github.com/NetApp/terrafor…

44182ac

…m-provider-netapp-ontap into 184-add-lambda-connector

Remove unused comments.

6c93776

Edit CHANGELOG.md

b9032d5

resolve conflict.

1336f97

Merge branch 'stable-1.1' into 265-docs-on-prem-ontap-version-is-wron…

8c8f80b

…g-for-resource-ip-route

Add new resource security role.

b3b97f0

carchi8py and others added 16 commits December 13, 2024 15:24

Merge pull request NetApp#357 from NetApp/dependabot/go_modules/githu…

95d14c4

…b.com/aws/aws-sdk-go-v2-1.32.6 Bump github.com/aws/aws-sdk-go-v2 from 1.30.3 to 1.32.6

Merge pull request NetApp#358 from NetApp/dependabot/go_modules/githu…

8ab8abf

…b.com/aws/aws-sdk-go-v2/config-1.28.6 Bump github.com/aws/aws-sdk-go-v2/config from 1.27.27 to 1.28.6

Merge pull request NetApp#351 from NetApp/move-to-2.1

c87bea9

update to 2.1

Merge pull request NetApp#359 from NetApp/dependabot/go_modules/githu…

09a7c75

…b.com/aws/aws-sdk-go-v2/service/lambda-1.69.1 Bump github.com/aws/aws-sdk-go-v2/service/lambda from 1.56.3 to 1.69.1

Merge pull request NetApp#361 from NetApp/dependabot/go_modules/githu…

6940670

…b.com/hashicorp/terraform-plugin-docs-0.20.1 Bump github.com/hashicorp/terraform-plugin-docs from 0.19.4 to 0.20.1

Merge pull request NetApp#364 from NetApp/dependabot/go_modules/githu…

134c45e

…b.com/aws/aws-sdk-go-v2/service/lambda-1.69.2 Bump github.com/aws/aws-sdk-go-v2/service/lambda from 1.69.1 to 1.69.2

go tidy"

ea5cf87

Merge pull request NetApp#366 from NetApp/tidy

b756460

go tidy"

Merge pull request NetApp#355 from NetApp/dependabot/go_modules/githu…

f087a67

…b.com/hashicorp/terraform-plugin-framework-validators-0.16.0 Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.12.0 to 0.16.0

Merge pull request NetApp#362 from NetApp/dependabot/go_modules/githu…

0eaabad

…b.com/hashicorp/terraform-plugin-sdk/v2-2.35.0 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.34.0 to 2.35.0

carchi8py added New Resource New Request for an ONTAP Resource and removed enhancement New feature or request labels Jan 6, 2025

carchi8py reviewed Jan 6, 2025

View reviewed changes

suhasbshekar requested changes Jan 7, 2025

View reviewed changes

acch added 6 commits January 13, 2025 12:13

feat: add svm_qos_policy_activation resource with numeric IDs

d16ec58

Signed-off-by: Achim Christ <[email protected]>

feat: allow referencing SVM / QoS Policy by name

5d72f01

Signed-off-by: Achim Christ <[email protected]>

feat: add resource import function

774fdea

Signed-off-by: Achim Christ <[email protected]>

chore: cleanup example

59f7340

Signed-off-by: Achim Christ <[email protected]>

feat: add acceptance tests for svm_qos_policy_activation resource

d8bc484

Signed-off-by: Achim Christ <[email protected]>

feat: add svm_qos_policy_activation documentation

35cfcb1

Signed-off-by: Achim Christ <[email protected]>

acch force-pushed the 301-svm-qos-policy-activation branch from 8c5e7f1 to 35cfcb1 Compare January 13, 2025 14:50

wenjun666 force-pushed the integration/main branch from 0eaabad to ed4593e Compare January 14, 2025 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement]: Add SVM QoS Policy Activation #346

[Enhancement]: Add SVM QoS Policy Activation #346

acch commented Dec 3, 2024 •

edited

Loading

carchi8py left a comment

suhasbshekar Jan 7, 2025

acch commented Jan 13, 2025

acch commented Jan 13, 2025

[Enhancement]: Add SVM QoS Policy Activation #346

Are you sure you want to change the base?

[Enhancement]: Add SVM QoS Policy Activation #346

Conversation

acch commented Dec 3, 2024 • edited Loading

carchi8py left a comment

Choose a reason for hiding this comment

suhasbshekar Jan 7, 2025

Choose a reason for hiding this comment

acch commented Jan 13, 2025

acch commented Jan 13, 2025

acch commented Dec 3, 2024 •

edited

Loading