Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uploadFile): fix Taro.uploadFile() #1115

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix(uploadFile): fix Taro.uploadFile() #1115

merged 1 commit into from
Nov 14, 2018

Conversation

OpenGG
Copy link
Contributor

@OpenGG OpenGG commented Nov 14, 2018

修复两个问题

  1. index.d.ts 中, uploadTask 缺乏progress()/abort()方法
  2. wx.uploadFile() 返回值可能是 undefined, 需要判断空调用

@OpenGG
fix(uploadFile): fix Taro.uploadFile()
430dc9f 
* 完善progress()/abort()方法声明
* wx.uploadFile() 的返回值可能是 undefined, 因此在 progress()/abort() 调用中需要防止空调用
@luckyadam
Copy link
Member

非常感谢~

@luckyadam luckyadam merged commit 23e7c0b into NervJS:master Nov 14, 2018
@taro-bot taro-bot bot mentioned this pull request Nov 19, 2018
Closed
Leechael pushed a commit to Leechael/taro that referenced this pull request Mar 15, 2019
@OpenGG @luckyadam
fix(taro): fix Taro.uploadFile() (NervJS#1115)
cdde72b 
* 完善progress()/abort()方法声明
* wx.uploadFile() 的返回值可能是 undefined, 因此在 progress()/abort() 调用中需要防止空调用
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OpenGG @luckyadam