Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVExport v2.1.23 has a small bug #547

Closed
xiaoyang2013 opened this issue Dec 11, 2024 · 15 comments · Fixed by #548
Closed

GVExport v2.1.23 has a small bug #547

xiaoyang2013 opened this issue Dec 11, 2024 · 15 comments · Fixed by #548
Labels
bug Something isn't working
Milestone

Comments

@xiaoyang2013
Copy link

When the administrator is not logged in, when entering the individual's GVExport from the menu bar at the top of the individual page, the xref individual marked by the current URL will not be located, but when the administrator account is logged in, it can be displayed normally in the "Include anyone related to" column.
2.1.21 does not have this problem

@Neriderc Neriderc added the bug Something isn't working label Dec 11, 2024
@Neriderc Neriderc added this to the 2.2.3 milestone Dec 11, 2024
@Neriderc
Copy link
Owner

Thanks for reporting this! I can confirm that I see the same, it works when logged in but not when logged out.

I'll try to find some time to dig into this soon, and will include it in the 2.2.3 release whenever that comes.

@xiaoyang2013
Copy link
Author

Can I also update it in v2.1? I don't have PHP 8.3 or above, so I can't install webtress 2.2.

@Neriderc
Copy link
Owner

Last week I released a GVExport 2.2.2 that should support webtrees 2.1. I took some ideas from other modules and created a helper function that checks the version and uses different methods depending on the version. It should now support both webtrees 2.1 and 2.2.

@Neriderc
Copy link
Owner

I have found the issue. A little while back we made the change to use javascript to load most of the settings for logged out users, because the cookie was becoming too large and was nearing the size limit. When this change was made, it meant the settings were loaded over top of the URL XREF and so the URL was effectively ignored, because of the asynchronous way the settings were loaded. Settings are loaded in a different way for logged in users so it didn't affect these users.

If you update from the main branch you should find that it is fixed. I'll work on some other changes in the coming days or weeks and wait to do a release until there is more in it.

@xiaoyang2013
Copy link
Author

asfdasd
Hello, is there any other place I need to change? I changed it on "GVExport v2.1.23", but it didn't take effect.

@Neriderc
Copy link
Owner

No, that's the change. Did you also check the setting:
treatment of source individuals

I added this on top of 2.2.2, but I can't see any changes between 2.1.23 and 2.2.2 that would affect this.

@xiaoyang2013
Copy link
Author

xiaoyang2013 commented Dec 12, 2024

Hi, I installed GVExport 2.2.2 on webtress2.1 today, but the problem still exists. When not logged in, the individual in the URL is displayed first, and then it automatically switches to the default individual in about 1 second.

111

2222

@Neriderc
Copy link
Owner

Neriderc commented Dec 12, 2024

Could you try two things for me?

First, can you update from the main branch? Here on GitHub, go to the "Code" tab (the main page). At the top left, can you check it says "main", then click the big green "Code" button and choose "Download zip" (mine is in dark mode, but in light mode it will look much the same but with white instead of black)

screen shot of above

Unzip and install this into the modules_v4 as you normally install. This should make sure we are both running the exact same version.

Secondly, can you hard-reload the page? Normally it's enough to hold Shift while you click the reload button in your browser or press Ctrl+Shift+R, but you can also use the option in your browser settings to clear the cache.

Also, what browser are you using?

@xiaoyang2013
Copy link
Author

Yes, I confirmed that I installed it this way: download the master branch, then delete all old GVExports, and then copy the complete GVExport package.

I tried two browsers: Google Chrome 109 and Firefox 115. I cleared the cache and cookies in both browsers.

@xiaoyang2013
Copy link
Author

The file size of the package I downloaded is: 2.06 MB (2,165,034 bytes)

@xiaoyang2013
Copy link
Author

xiaoyang2013 commented Dec 12, 2024

This is the version number I saw in the Admin Center

sdf

@Neriderc
Copy link
Owner

I've identified a potential race condition, possibly causing things to happen out of order. I'll work on getting a new version for you to test, but I've found another issue I'm trying to resolve and it's taking a bit of time.

@xiaoyang2013
Copy link
Author

Thank you very much, it was a pleasure to test.

@Neriderc Neriderc mentioned this issue Dec 13, 2024
@Neriderc
Copy link
Owner

I've just merged another pull request that I hope will address the issue. Can you update from the main branch again and see if it's working?

@xiaoyang2013
Copy link
Author

xiaoyang2013 commented Dec 13, 2024

Yes, I see the problem has been solved, and I am very grateful for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants