Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting settings no longer works #502

Closed
Neriderc opened this issue Aug 26, 2024 · 4 comments · Fixed by #503
Closed

Overwriting settings no longer works #502

Neriderc opened this issue Aug 26, 2024 · 4 comments · Fixed by #503
Labels
bug Something isn't working
Milestone

Comments

@Neriderc
Copy link
Owner

It seems refactoring in the last release has broken the ability to overwrite a setting in the advanced saved settings list.

When saving a setting, if you save with the same name as an existing setting it should overwrite that setting (after prompting the user to confirm that's what they want to do).

It seems the prompt appears, but no actual saving occurs.

@Neriderc Neriderc added the bug Something isn't working label Aug 26, 2024
@Neriderc Neriderc added this to the 2.1.22 milestone Aug 26, 2024
@schuco
Copy link

schuco commented Aug 26, 2024

Sorry, but in my case the fix did not help.
There is the prompt to confirm overwriting, but no confirmation or indication, that it was done.
I have made a reset after overwriting, reloaded the saved setting, but the intended change has not been saved.

@Neriderc
Copy link
Owner Author

Sorry, this was the issue I created to track the issue. Once I've actually fixed it, I close the issue.

I've merged in the fix now, so if you update from the main branch you should find it's fixed.

Just a warning, I was wrong about the "Action when individual clicked" not being included in saved settings. It is included, however, I believe it is ignored if you are loading old settings that were created before the new setting was added. That should work in your favour, as the setting should stay the same as you load the older settings.

Regardless, you should be able to update the settings now if you need to. Click a setting to load it, change what you want to change, then save it again. So long as you keep the same name, it should overwrite it.

@schuco
Copy link

schuco commented Aug 26, 2024

It works as promised. Thank you very much!

@Neriderc
Copy link
Owner Author

Great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants