Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PADherder 'jp_only' flag #71

Closed
madcowfred opened this issue Jan 2, 2015 · 2 comments
Closed

Ignore PADherder 'jp_only' flag #71

madcowfred opened this issue Jan 2, 2015 · 2 comments

Comments

@madcowfred
Copy link
Contributor

As per title, just add monsters even if the PADherder data claims JP only. Nothing on PADherder's end actually cares if they are or not, it just means I get "X's name is in Japanese" reports rather than PADLISTENER DON'T WORK :person_frowning:

@JamesCID
Copy link

JamesCID commented Jan 2, 2015

And I'm one of the buggers reporting those issues, so I second it.

@Neraud
Copy link
Owner

Neraud commented Jan 2, 2015

I added the jp_only check to prevent issues with monsters being released in JP with ids already used in NA (I still have nightmares about the BAO monsters ;p). In this case, I suppose the monsters will first be created with only an id_jp and jp_only = true, and then it would be updated with an id_us and jp_only = false.
But it seems it's causing issues to prevent something that should not happen.

I'll remove it.

@Neraud Neraud closed this as completed in 4cfe73e Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants