Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Text-image pairs are becoming scrambled. #31

Closed
UrzasLegacy opened this issue Sep 29, 2024 · 2 comments
Closed

Bug: Text-image pairs are becoming scrambled. #31

UrzasLegacy opened this issue Sep 29, 2024 · 2 comments

Comments

@UrzasLegacy
Copy link
Contributor

UrzasLegacy commented Sep 29, 2024

- Sometimes when usingdelete pair, the contents of the text box seem to automatically get saved to that index. For example: I delete index 4 and now index 5 has the text saved to it instead.

I'm not 100% sure if this is what happened with me, but I noticed at some point that some of my text image pairs were swapped. Very painful bug to rectify!

I love your app, so I wanted to see if I could bang this one out. I noticed in your Todo section you are already aware of the issue :P Have you made any headway?

Edit: After looking at it a bit, would setting save to False on these two calls to update_pair fix the issue?

self.update_pair("prev")

self.update_pair("prev")

Added these changes to my PR for review.

@Nenotriple
Copy link
Owner

Nenotriple commented Sep 29, 2024

I'm sorry you had to deal with the app messing with your captions. It's something that should have been fixed earlier.

I seriously appreciate that you've looked into this yourself, your changes appear to have fixed the issue, and I've merged your pull request. #30

@UrzasLegacy
Copy link
Contributor Author

No problem at all! Thank you for developing this, I'm happy to be able to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants