From 2b2da3a78b5ae0d0653cd1e63e9fbbcdc47b1f1e Mon Sep 17 00:00:00 2001 From: William Hart Date: Thu, 5 Nov 2020 02:32:14 +0100 Subject: [PATCH 1/5] Update generic tests for changes in AbstractAlgebra. --- test/generic/Matrix-test.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/generic/Matrix-test.jl b/test/generic/Matrix-test.jl index 27b83c6277..c5e9164f97 100644 --- a/test/generic/Matrix-test.jl +++ b/test/generic/Matrix-test.jl @@ -133,9 +133,9 @@ end M = randmat_with_rank(S, dim, -100:100) b = rand(T, -100:100) - x, d = Generic.solve_fflu(M, b) + flag, x, d = Generic.can_solve_with_solution_fflu(M, b) - @test divexact(M, d)*x == b + @test flag && divexact(M, d)*x == b end end @@ -150,9 +150,9 @@ end M = randmat_with_rank(S, dim, -100:100) b = rand(T, -100:100) - x = Generic.solve_lu(M, b) + flag, x = Generic.can_solve_with_solution_lu(M, b) - @test M*x == b + @test flag && M*x == b end end From ffe5f9bcd7f4ad36358359659cf47b7396ef9b0f Mon Sep 17 00:00:00 2001 From: wbhart Date: Thu, 5 Nov 2020 12:14:12 +0100 Subject: [PATCH 2/5] Update test/generic/Matrix-test.jl Co-authored-by: Rafael Fourquet --- test/generic/Matrix-test.jl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/generic/Matrix-test.jl b/test/generic/Matrix-test.jl index c5e9164f97..ea3698a702 100644 --- a/test/generic/Matrix-test.jl +++ b/test/generic/Matrix-test.jl @@ -133,7 +133,12 @@ end M = randmat_with_rank(S, dim, -100:100) b = rand(T, -100:100) - flag, x, d = Generic.can_solve_with_solution_fflu(M, b) + if isdefined(Generic, :can_solve_with_solution_fflu) + flag, x, d = Generic.can_solve_with_solution_fflu(M, b) + @test flag + else + x, d = Generic.solve_fflu(M, b) + end @test flag && divexact(M, d)*x == b end From 5eee73429a975997a47540bd01bd92e34e891c0a Mon Sep 17 00:00:00 2001 From: wbhart Date: Thu, 5 Nov 2020 12:17:20 +0100 Subject: [PATCH 3/5] Update test/generic/Matrix-test.jl Co-authored-by: Rafael Fourquet --- test/generic/Matrix-test.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/generic/Matrix-test.jl b/test/generic/Matrix-test.jl index ea3698a702..daf5dbc3b7 100644 --- a/test/generic/Matrix-test.jl +++ b/test/generic/Matrix-test.jl @@ -140,7 +140,7 @@ end x, d = Generic.solve_fflu(M, b) end - @test flag && divexact(M, d)*x == b + @test divexact(M, d)*x == b end end From e033829ef971ba4cff6fcaf482fbe6713333ea53 Mon Sep 17 00:00:00 2001 From: Rafael Fourquet Date: Thu, 5 Nov 2020 12:39:31 +0100 Subject: [PATCH 4/5] Update test/generic/Matrix-test.jl --- test/generic/Matrix-test.jl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/generic/Matrix-test.jl b/test/generic/Matrix-test.jl index daf5dbc3b7..6b092d442b 100644 --- a/test/generic/Matrix-test.jl +++ b/test/generic/Matrix-test.jl @@ -155,7 +155,12 @@ end M = randmat_with_rank(S, dim, -100:100) b = rand(T, -100:100) - flag, x = Generic.can_solve_with_solution_lu(M, b) + if isdefined(Generic, :can_solve_with_solution_lu) + flag, x = Generic.can_solve_with_solution_lu(M, b) + @test flag + else + x = Generic.solve_lu(M, b) + end @test flag && M*x == b end From e7696e9630105bae0800abf5f4eee5e374d9c616 Mon Sep 17 00:00:00 2001 From: Rafael Fourquet Date: Thu, 5 Nov 2020 12:39:41 +0100 Subject: [PATCH 5/5] Update test/generic/Matrix-test.jl --- test/generic/Matrix-test.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/generic/Matrix-test.jl b/test/generic/Matrix-test.jl index 6b092d442b..57df1fe708 100644 --- a/test/generic/Matrix-test.jl +++ b/test/generic/Matrix-test.jl @@ -162,7 +162,7 @@ end x = Generic.solve_lu(M, b) end - @test flag && M*x == b + @test M*x == b end end