Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start-gateway-config.sh not using DIAGNOSTICS_JSON_URL #263

Open
softlion opened this issue Feb 11, 2024 · 2 comments
Open

start-gateway-config.sh not using DIAGNOSTICS_JSON_URL #263

softlion opened this issue Feb 11, 2024 · 2 comments

Comments

@softlion
Copy link

softlion commented Feb 11, 2024 •
edited
Loading

start-gateway-config.sh is using the hardcoded string http://diagnostics/json instead of DIAGNOSTICS_JSON_URL
@shawaj
Copy link
Member

shawaj commented Jul 4, 2024

Iirc diagnostics json url is only assigned in the python part of the library so don't thing is available at this stage of startup.

I might be wrong however, as it's been a while since I've dug into this area

@shawaj
Copy link
Member

shawaj commented Jul 4, 2024

Yeah it's set here but only for the python library...

hm-config/gatewayconfig/__main__.py

Line 21 in a198b83

DIAGNOSTICS_JSON_URL = os.getenv(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@softlion @shawaj