Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data mover daemon RPM build does not contain github commit hash #84

Closed
NateThornton opened this issue Feb 9, 2023 · 1 comment
Closed
Assignees

Comments

@NateThornton
Copy link
Contributor

NateThornton commented Feb 9, 2023

The RPM build does not provide the correct GitHub commit hash, so the daemon is reporting v0.0.1-unknown

When using the build-daemon make target, the commit hash is loaded from git

nnf-dm/Makefile

Lines 123 to 126 in d5df11f

build-daemon: COMMIT_HASH = $(shell git rev-parse --short HEAD)
build-daemon: PACKAGE = github.com/NearNodeFlash/nnf-dm/daemons/compute/server/version
build-daemon: manifests generate fmt vet ## Build standalone nnf-datamovement daemon
GOOS=linux GOARCH=amd64 go build -ldflags="-X '$(PACKAGE).commitHash=$(COMMIT_HASH)'" -o bin/nnf-dm daemons/compute/server/main.go

If this fails, the default value is "unknown"

commitHash = "unknown"

@bdevcich
Copy link
Contributor

bdevcich commented Mar 8, 2023

Closing this as @matthew-richerson merged #87.

@bdevcich bdevcich closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from 📋 Open to ✅ Closed in Issues Dashboard Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants