Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resuming transfer commands #145

Closed
MaksymZavershynskyi opened this issue Jul 7, 2020 · 2 comments
Closed

Resuming transfer commands #145

MaksymZavershynskyi opened this issue Jul 7, 2020 · 2 comments
Assignees

Comments

@MaksymZavershynskyi
Copy link
Contributor

transfer-eth-erc20-to-near and transfer-eth-erc20-from-near should be resumable. In production setting they will take long time to execute (minutes or hours) because they will be waiting for the blocks to be submitted or become valid. During this time the command can be accidentally or purposefully terminated. After such termination it should be possible to resume the transfer. We need to complete two things to achieve this:

  • Transfer commands need to log in high detail every transaction they execute, so that if transfer is terminated in a random spot it can be resumed manually by reading through logs;
  • The most common spot for termination would be when command is waiting for blocks. Before transfer starts waiting for the blocks it should print into stdout arguments that can be used to resume this command if it terminates.
@ailisp
Copy link
Contributor

ailisp commented Jul 20, 2020

transfer-eth-erc20-to-near is done in #188 , if this approach looks good i'll also use similar for transfer-eth-erc20-from-near

@ailisp ailisp linked a pull request Aug 22, 2020 that will close this issue
@ailisp
Copy link
Contributor

ailisp commented Aug 27, 2020

This is done in rainbow-bridge-lib

@ailisp ailisp closed this as completed Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants