Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgradable::up_stage_code should take param code: Option<Vec<u8>> #73

Open
mooori opened this issue Jan 24, 2023 · 0 comments
Open

Upgradable::up_stage_code should take param code: Option<Vec<u8>> #73

mooori opened this issue Jan 24, 2023 · 0 comments
Assignees
@mooori

Comments

@mooori
Copy link
Contributor

mooori commented Jan 24, 2023

...with None removing any staged code. This is more idiomatic than removing staged code when the vector passed to up_stage_code is empty:

https://github.com/aurora-is-near/near-plugins/blob/c043add4c2a0810872c4326a55c5162bccd3f4ee/near-plugins-derive/src/upgradable.rs#L32-L39

The possibility to remove staged code should also be mentioned in the docs.

The issue is based on this discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mooori mooori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mooori