Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using LookupMap instead LookupSet for used_proofs #39

Closed
olga24912 opened this issue May 10, 2023 · 1 comment · Fixed by #50
Closed

Using LookupMap instead LookupSet for used_proofs #39

olga24912 opened this issue May 10, 2023 · 1 comment · Fixed by #50
Assignees
@mrLSD
Labels
enhancement New feature or request
Milestone
v0.5.1

Comments

@olga24912
Copy link
Collaborator

For storing used_proofs in EthConnectorContract currently the LookupMap is used. However only true value is stored to this map and the value is never checked.

So, it makes sense to change LookupMap into LookupSet: https://docs.rs/near-sdk/latest/near_sdk/collections/struct.LookupSet.html
@aleksuss aleksuss mentioned this issue May 15, 2023
Merged
@mrLSD mrLSD added this to the v0.5.1 milestone May 15, 2023
@mrLSD mrLSD self-assigned this May 15, 2023
@mrLSD mrLSD added the enhancement New feature or request label May 15, 2023
@mrLSD
Copy link
Collaborator

mrLSD commented May 15, 2023

Refactored at #50

@mrLSD mrLSD closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrLSD mrLSD

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

chore: use LookupSet instead of Vec and LookupMap Near-One/aurora-eth-connector
2 participants
@mrLSD @olga24912