fix(css-android): restore elements' native features if offending css is removed while the app is running #7789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoldonev
changed the title
manoldonev
reviewed
Sep 13, 2019
manoldonev
changed the title
…r CSS disabled them is removed (e.g. border-width > 0, border-radius > 0, background-image, etc.)
bundyo
force-pushed
the
bundev/fix-removing-border-not-returning-ripple
branch
from
f4556fc to
797a6ed
Compare
manoldonev
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. border-width > 0, border-radius > 0, background-image, etc.)
PR Checklist
What is the current behavior?
When the user sets border-width, border-radius or others, the native features of the control are removed, but can't be restored when adding additional CSS later.
What is the new behavior?
The native features are restored by just applying the filter on top of a new drawable.
Fixes/Implements/Closes #7788.