-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: require devtools-elements.js with the extension mentioned explicitly #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)
ghost
assigned sis0k0
Jul 17, 2018
ghost
added
the
in progress
label
Jul 17, 2018
sis0k0
changed the title
fix(devtools): require .js file explicitly
fix: require devtools-elements.js with the extension mentioned explicitly
Jul 17, 2018
manoldonev
approved these changes
Jul 17, 2018
test |
ghost
assigned manoldonev
Jul 18, 2018
ghost
removed
the
in progress
label
Jul 18, 2018
sis0k0
added a commit
that referenced
this pull request
Jul 18, 2018
…itly (#6079) This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)
dtopuzov
pushed a commit
that referenced
this pull request
Jul 18, 2018
* fix: require devtools-elements.js with the extension mentioned explicitly (#6079) This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment) * release: cut the 4.1.1 release * chore: Fix TS transpile error with 2.9 (#5906)
vchimev
added a commit
that referenced
this pull request
Jun 12, 2019
#6079 workarounds an issue in @ngtools/webpack which is no more. Reverting the workaround as: - the original issue is no more - the require does not resolve when transpiling `tns-core-modules`
vchimev
added a commit
that referenced
this pull request
Jun 13, 2019
#6079 workarounds an issue in @ngtools/webpack which is no more. Reverting the workaround as: - the original issue is no more - the require does not resolve when transpiling `tns-core-modules`
vakrilov
pushed a commit
that referenced
this pull request
Jun 17, 2019
#6079 workarounds an issue in @ngtools/webpack which is no more. Reverting the workaround as: - the original issue is no more - the require does not resolve when transpiling `tns-core-modules`
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue with
@ngtools/[email protected]
, described here: NativeScript/nativescript-dev-webpack#607 (comment)