Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require devtools-elements.js with the extension mentioned explicitly #6079

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jul 17, 2018

This is a workaround for the issue with @ngtools/[email protected], described here: NativeScript/nativescript-dev-webpack#607 (comment)

@sis0k0 sis0k0 requested a review from manoldonev July 17, 2018 11:44
@ghost ghost assigned sis0k0 Jul 17, 2018
@ghost ghost added the in progress label Jul 17, 2018
@sis0k0 sis0k0 changed the title fix(devtools): require .js file explicitly fix: require devtools-elements.js with the extension mentioned explicitly Jul 17, 2018
@manoldonev
Copy link
Contributor

test

@ghost ghost assigned manoldonev Jul 18, 2018
@sis0k0 sis0k0 merged commit 8813e9b into master Jul 18, 2018
@ghost ghost removed the in progress label Jul 18, 2018
@sis0k0 sis0k0 deleted the sis0k0/dynamic-require-js branch July 18, 2018 10:38
sis0k0 added a commit that referenced this pull request Jul 18, 2018
dtopuzov pushed a commit that referenced this pull request Jul 18, 2018
* fix: require devtools-elements.js with the extension mentioned explicitly (#6079)

This is a workaround for the issue with `@ngtools/[email protected]`, described here: NativeScript/nativescript-dev-webpack#607 (comment)

* release: cut the 4.1.1 release

* chore: Fix TS transpile error with 2.9 (#5906)
vchimev added a commit that referenced this pull request Jun 12, 2019
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
vchimev added a commit that referenced this pull request Jun 13, 2019
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
vakrilov pushed a commit that referenced this pull request Jun 17, 2019
#6079
workarounds an issue in @ngtools/webpack which is no more.

Reverting the workaround as:
- the original issue is no more
- the require does not resolve when transpiling `tns-core-modules`
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants