fix(core/properties): Fix typings for nativeValueChange #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
manoldonev
reviewed
May 8, 2018
| @@ -52,7 +52,7 @@ export class Property<T extends ViewBase, U> { | |||
| public readonly setNative: symbol; | |||
| public readonly defaultValue: U; | |||
| public register(cls: { prototype: T }): void; | |||
| public nativeValueChange(T, U): void; | |||
| public nativeValueChange(target:T, value:U): void; | |||
There was a problem hiding this comment.
First argument is generally referred as owner across the codebase:
Can you update this?
|
Hey @speigg |
Changed parameter name of nativeValueChange from “target” to “owner” Fixed white space to match coding style
Fixed white space
|
I made the changes directly on Github.com, as I don’t have the {N} repository downloded and setup for development. Anyway, the CI seems to be happy about the whitespace now. |
vakrilov
approved these changes
Jun 19, 2018
|
test |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.