Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker minHour, maxHour are throwing exception when hour is out of their range #1916

Closed
NickIliev opened this issue Apr 8, 2016 · 4 comments · Fixed by #1955
Closed
Labels
bug os: android ready for test TSC needs to test this and confirm against live production apps and automated test suites
Milestone

Comments

@NickIliev
Copy link
Contributor

When we have set minHour or/and maxHour and the user picks a hour smaller/larger then the pre-set limitations we are throwing an exception.

For example:

<TimePicker hour="5" minute="30" minHour="3" maxHour="7" />

This will create a time picker with all possible hours
and will throw exception when hour is smaller then 3 and larger then 7

Error: Hour property value (02:00) is not valid. Min time: (03:00), max time: (07:59).

@enchev enchev added this to the 2.0.0 milestone Apr 13, 2016
@enchev enchev self-assigned this Apr 13, 2016
@enchev enchev added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Apr 13, 2016
@niyazhussain
Copy link

I am facing the same issue in IOS, please tag me once fixed.

@Macarthurval
Copy link

Macarthurval commented Oct 18, 2017

Still the error in iOs when maxHour and maxMinute are defined, changing hour and falling out of the range by minutes gilt.

Example:

max: 09:00
current: 08:30
move a hour forward: 09:30

It crash instead of autoadjust to 9:00 :

Error: Hour property value (09:30) is not valid. Min time: (00:00), max time: (09:00).

@Dagrut
Copy link

Dagrut commented Jan 31, 2019

Same error here...
Is there a workaround? I tried setting the value myself with hour/minute or with v-model after a change event, but nothing works 😞

@lock
Copy link

lock bot commented Jan 31, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug os: android ready for test TSC needs to test this and confirm against live production apps and automated test suites
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants